Attachment 87731 Details for Bug 200240 – fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix

clipboard.txt (text/plain), 3.42 KB, created by Steffen Pingel

on 2008-01-23 23:13:10 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Steffen Pingel

Created: 2008-01-23 23:13:10 EST

Size: 3.42 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/tasks/ui/editors/TaskEditor.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/TaskEditor.java,v
>retrieving revision 1.66
>diff -u -r1.66 TaskEditor.java
>--- src/org/eclipse/mylyn/tasks/ui/editors/TaskEditor.java	7 Jan 2008 04:14:52 -0000	1.66
>+++ src/org/eclipse/mylyn/tasks/ui/editors/TaskEditor.java	24 Jan 2008 04:06:24 -0000
>@@ -41,6 +41,7 @@
> import org.eclipse.ui.forms.editor.FormPage;
> import org.eclipse.ui.forms.editor.IFormPage;
> import org.eclipse.ui.forms.editor.SharedHeaderFormEditor;
>+import org.eclipse.ui.forms.events.IHyperlinkListener;
> import org.eclipse.ui.forms.widgets.Form;
> import org.eclipse.ui.progress.IWorkbenchSiteProgressService;
> 
>@@ -69,6 +70,8 @@
> 
> 	private EditorBusyIndicator editorBusyIndicator;
> 
>+	private IHyperlinkListener messageHyperLinkListener;
>+
> 	public TaskEditor() {
> 		super();
> 		taskPlanningEditor = new TaskPlanningEditor(this);
>@@ -434,14 +437,30 @@
> 		return this.getHeaderForm().getForm().getForm();
> 	}
> 
>-	public void setMessage(String message, int type) {
>+	/**
>+	 * @since 2.3 
>+	 */
>+	public void setMessage(String message, int type, IHyperlinkListener listener) {
> 		if (this.getHeaderForm() != null && this.getHeaderForm().getForm() != null) {
> 			if (!this.getHeaderForm().getForm().isDisposed()) {
>-				this.getHeaderForm().getForm().setMessage(message, type);
>+				getTopForm().setMessage(message, type);
>+				
>+				if (messageHyperLinkListener != null) {
>+					getTopForm().removeMessageHyperlinkListener(messageHyperLinkListener);
>+				}
>+				if (listener != null) {
>+					getTopForm().addMessageHyperlinkListener(listener);
>+					//this.getHeaderForm().getForm().setMessage(message, type);
>+				}
>+				messageHyperLinkListener = listener;
> 			}
> 		}
> 	}
> 
>+	public void setMessage(String message, int type) {
>+		setMessage(message, type, null);
>+	}
>+	
> 	protected IWorkbenchSiteProgressService getProgressService() {
> 		Object siteService = getEditorSite().getAdapter(IWorkbenchSiteProgressService.class);
> 		if (siteService != null)
>Index: src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java,v
>retrieving revision 1.261
>diff -u -r1.261 AbstractRepositoryTaskEditor.java
>--- src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java	22 Jan 2008 21:16:00 -0000	1.261
>+++ src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java	24 Jan 2008 04:06:24 -0000
>@@ -404,13 +404,12 @@
> 							// "Changed - " + repositoryTask.getSummary(),
> 							// "Editor will Test with new incoming
> 							// changes.");
>-							parentEditor.getTopForm().addMessageHyperlinkListener(new HyperlinkAdapter() {
>-								public void linkActivated(HyperlinkEvent e) {
>-									refreshEditor();
>-								}
>-							});
> 							parentEditor.setMessage("Task has incoming changes, synchronize to view",
>-									IMessageProvider.WARNING);
>+									IMessageProvider.WARNING, new HyperlinkAdapter() {
>+										public void linkActivated(HyperlinkEvent e) {
>+											refreshEditor();
>+										}
>+									});
> 
> 							setSubmitEnabled(false);
> 							// updateContents();

Actions: View | Diff

Attachments on bug 200240: 83127 | 84696 | 87731 | 87732