Attachment 87569 Details for Bug 212071 – Better handling of image and text setters in GalleryViewerRow

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Better handling of image and text setters in GalleryViewerRow

GalleryViewerRowSetters.patch (text/plain), 1.04 KB, created by Peter Centgraf

on 2008-01-22 16:58:00 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Centgraf

Created: 2008-01-22 16:58:00 EST

Size: 1.04 KB

patch

obsolete

>Index: src/org/eclipse/nebula/jface/galleryviewer/GalleryViewerRow.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.swt.nebula/org.eclipse.nebula.widgets.gallery/src/org/eclipse/nebula/jface/galleryviewer/GalleryViewerRow.java,v
>retrieving revision 1.2
>diff -u -r1.2 GalleryViewerRow.java
>--- src/org/eclipse/nebula/jface/galleryviewer/GalleryViewerRow.java	11 Jan 2008 07:58:10 -0000	1.2
>+++ src/org/eclipse/nebula/jface/galleryviewer/GalleryViewerRow.java	22 Jan 2008 21:55:42 -0000
>@@ -270,7 +270,10 @@
> 	 *      org.eclipse.swt.graphics.Image)
> 	 */
> 	public void setImage(int columnIndex, Image image) {
>-		item.setImage(image);
>+		Image oldImage = item.getImage();
>+		if (image != oldImage) {
>+			item.setImage(image);
>+		}
> 	}
> 
> 	/*
>@@ -279,7 +282,7 @@
> 	 * @see org.eclipse.jface.viewers.ViewerRow#setText(int, java.lang.String)
> 	 */
> 	public void setText(int columnIndex, String text) {
>-		item.setText(text);
>+		item.setText(text == null ? "" : text);
> 	}
> 
> }

Flags:

nicolas.richeton: iplog+

Actions: View

Attachments on bug 212071: 84678 | 84766 | 87569 | 87570