Attachment 86430 Details for Bug 212799 – Patch with the fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch with the fix

patch-212799.txt (text/plain), 3.19 KB, created by Marius Slavescu

on 2008-01-08 16:16:35 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Marius Slavescu

Created: 2008-01-08 16:16:35 EST

Size: 3.19 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.tptp.platform.log.views
>Index: src/org/eclipse/tptp/platform/log/views/internal/views/LogViewerUI.java
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.tptp.platform.log.views/src/org/eclipse/tptp/platform/log/views/internal/views/LogViewerUI.java,v
>retrieving revision 1.37
>diff -u -r1.37 LogViewerUI.java
>--- src/org/eclipse/tptp/platform/log/views/internal/views/LogViewerUI.java	27 Nov 2007 04:33:39 -0000	1.37
>+++ src/org/eclipse/tptp/platform/log/views/internal/views/LogViewerUI.java	8 Jan 2008 21:13:29 -0000
>@@ -4,7 +4,7 @@
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>  * http://www.eclipse.org/legal/epl-v10.html
>- * $Id: LogViewerUI.java,v 1.37 2007/11/27 04:33:39 apnan Exp $
>+ * $Id: LogViewerUI.java,v 1.35 2007/08/08 14:54:16 ewchan Exp $
>  * 
>  * Contributors: 
>  * IBM - Initial API and implementation
>@@ -74,6 +74,7 @@
> 	
> 	private boolean _handleSelectionEvent = true;
> 	private boolean _controlDown=false;
>+	private boolean tableColumSelected=false;
> 	
> 	//return true when the first column header is selected while pressing the ctrl button
> 	private boolean _firstCol=true;
>@@ -158,7 +159,6 @@
> 		// Create the viewers
> 		return fTableViewer.getControl();
> 	}
>-	
> 	/**
> 	 * Creates the context menu for the method viewer
> 	 */
>@@ -200,10 +200,11 @@
> 		if(initSel != null && initSel.size() > 0){
> 			revealObject((EObject)initSel.get(0));
> 			EObject initInput = ((LogViewer)((LogPage)fPage).getTraceViewer()).getInitInput();			
>+
> 			if(initInput != null){
> 				TraceUIManager.getTraceUIManager().getSelectionModel(initInput).add(initSel.get(0));
>-			}
>-			((LogViewer)((LogPage)fPage).getTraceViewer()).setInitSelection(null);
>+			}			((LogViewer)((LogPage)fPage).getTraceViewer()).setInitSelection(null);
>+
> 			
> 		}else{
> 			setViewSelection();
>@@ -322,12 +323,22 @@
> 				updateColumnsTitle();
> 				
> 				if(!_controlDown)
>+				{
> 					updateSort();
>+					tableColumSelected=false;
>+				}
>+				else
>+					tableColumSelected=true;
> 			}
> 		}
> 		else if(e.item instanceof TableItem && e.item.getData()!=null && _handleSelectionEvent){	
>-			LogUtil.notifyViewSelectionChanged(this, fTableViewer.getInput() instanceof EObject ? (EObject)fTableViewer.getInput() : HyadesUtil.getMofObject(),e.item.getData());	
>+			LogUtil.notifyViewSelectionChanged(this, fTableViewer.getInput() instanceof EObject ? (EObject)fTableViewer.getInput() : HyadesUtil.getMofObject(),e.item.getData());
>+			tableColumSelected=false;
>+		}
>+		else {
>+			tableColumSelected=false;
> 		}
>+			
> 	}
> 	
> 	
>@@ -518,10 +529,15 @@
> 	
> 	public void keyReleased (KeyEvent e)  {
> 		if (e.keyCode == SWT.CONTROL) {
>-			ISelection selection = fTableViewer.getSelection(true);
> 			_controlDown = false;
>-			updateSort();			
>-			fTableViewer.setSelection(selection);
>+			if(tableColumSelected)
>+			{
>+				tableColumSelected=false;
>+				ISelection selection = fTableViewer.getSelection();
>+				updateSort();
>+				if(selection!=null)
>+					fTableViewer.setSelection(selection);
>+			}
> 		}
> 	}
>

Actions: View | Diff

Attachments on bug 212799: 86430 | 86536 | 86537