Attachment 82649 Details for Bug 209220 – fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix

fix_209220.txt (text/plain), 2.82 KB, created by Benno Baumgartner

on 2007-11-12 05:05:56 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Benno Baumgartner

Created: 2007-11-12 05:05:56 EST

Size: 2.82 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.ui
>Index: ui/org/eclipse/jdt/ui/wizards/NewJavaProjectWizardPageOne.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/wizards/NewJavaProjectWizardPageOne.java,v
>retrieving revision 1.5
>diff -u -r1.5 NewJavaProjectWizardPageOne.java
>--- ui/org/eclipse/jdt/ui/wizards/NewJavaProjectWizardPageOne.java	3 Oct 2007 09:13:15 -0000	1.5
>+++ ui/org/eclipse/jdt/ui/wizards/NewJavaProjectWizardPageOne.java	12 Nov 2007 10:05:36 -0000
>@@ -455,10 +455,10 @@
> 		public Control createControl(Composite composite) {
> 			fGroup= new Group(composite, SWT.NONE);
> 			fGroup.setFont(composite.getFont());
>-			fGroup.setLayout(initGridLayout(new GridLayout(3, false), true));
>+			fGroup.setLayout(initGridLayout(new GridLayout(2, false), true));
> 			fGroup.setText(NewWizardMessages.NewJavaProjectWizardPageOne_JREGroup_title);
> 
>-			fUseDefaultJRE.doFillIntoGrid(fGroup, 2);
>+			fUseDefaultJRE.doFillIntoGrid(fGroup, 1);
> 
> 			fPreferenceLink= new Link(fGroup, SWT.NONE);
> 			fPreferenceLink.setFont(fGroup.getFont());
>@@ -466,22 +466,25 @@
> 			fPreferenceLink.setLayoutData(new GridData(GridData.END, GridData.CENTER, false, false));
> 			fPreferenceLink.addSelectionListener(this);
> 
>-			fUseProjectJRE.doFillIntoGrid(fGroup, 1);
>+			Composite nonDefaultJREComposite= new Composite(fGroup, SWT.NONE);
>+			nonDefaultJREComposite.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false));
>+			GridLayout layout= new GridLayout(2, false);
>+			layout.marginHeight= 0;
>+			layout.marginWidth= 0;
>+			nonDefaultJREComposite.setLayout(layout);
> 
>-			Combo comboControl= fJRECombo.getComboControl(fGroup);
>-			comboControl.setLayoutData(new GridData(GridData.FILL, GridData.CENTER, true, false)); // make sure column 2 is grabbing (but no fill)
>-			comboControl.setVisibleItemCount(30);
>+			fUseProjectJRE.doFillIntoGrid(nonDefaultJREComposite, 1);
> 
>-			DialogField.createEmptySpace(fGroup);
>+			Combo comboControl= fJRECombo.getComboControl(nonDefaultJREComposite);
>+			comboControl.setLayoutData(new GridData(GridData.FILL, GridData.CENTER, true, false));
>+			comboControl.setVisibleItemCount(30);
> 
>-			fUseEEJRE.doFillIntoGrid(fGroup, 1);
>+			fUseEEJRE.doFillIntoGrid(nonDefaultJREComposite, 1);
> 
>-			Combo eeComboControl= fEECombo.getComboControl(fGroup);
>-			eeComboControl.setLayoutData(new GridData(GridData.FILL, GridData.CENTER, true, false)); // make sure column 2 is grabbing (but no fill)
>+			Combo eeComboControl= fEECombo.getComboControl(nonDefaultJREComposite);
>+			eeComboControl.setLayoutData(new GridData(GridData.FILL, GridData.CENTER, true, false));
> 			eeComboControl.setVisibleItemCount(30);
> 
>-			DialogField.createEmptySpace(fGroup);
>-
> 			updateEnableState();
> 			return fGroup;
> 		}

Actions: View | Diff

Attachments on bug 209220: 82649