Attachment 80261 Details for Bug 168597 – Patch for org.eclipse.hyades.test.ui

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Patch for org.eclipse.hyades.test.ui

bugzilla168597test.ui.txt (text/plain), 6.29 KB, created by DuWayne Morris

on 2007-10-12 14:06:59 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: DuWayne Morris

Created: 2007-10-12 14:06:59 EDT

Size: 6.29 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.hyades.test.ui
>Index: META-INF/MANIFEST.MF
>===================================================================
>RCS file: /cvsroot/tptp/test/org.eclipse.hyades.test.ui/META-INF/MANIFEST.MF,v
>retrieving revision 1.20
>diff -u -r1.20 MANIFEST.MF
>--- META-INF/MANIFEST.MF	24 Apr 2007 15:31:50 -0000	1.20
>+++ META-INF/MANIFEST.MF	12 Oct 2007 17:57:07 -0000
>@@ -2,7 +2,7 @@
> Bundle-ManifestVersion: 2
> Bundle-Name: %PLUGIN_NAME
> Bundle-SymbolicName: org.eclipse.hyades.test.ui; singleton:=true
>-Bundle-Version: 4.2.200.qualifier
>+Bundle-Version: 4.4.100.qualifier
> Bundle-Activator: org.eclipse.hyades.test.ui.UiPlugin
> Bundle-Vendor: %PROVIDER_NAME
> Bundle-Localization: plugin
>Index: src-recorder/org/eclipse/hyades/internal/execution/recorder/ui/wizards/RecorderRegistryInfo.java
>===================================================================
>RCS file: /cvsroot/tptp/test/org.eclipse.hyades.test.ui/src-recorder/org/eclipse/hyades/internal/execution/recorder/ui/wizards/RecorderRegistryInfo.java,v
>retrieving revision 1.12
>diff -u -r1.12 RecorderRegistryInfo.java
>--- src-recorder/org/eclipse/hyades/internal/execution/recorder/ui/wizards/RecorderRegistryInfo.java	26 Apr 2007 20:49:40 -0000	1.12
>+++ src-recorder/org/eclipse/hyades/internal/execution/recorder/ui/wizards/RecorderRegistryInfo.java	12 Oct 2007 17:57:07 -0000
>@@ -27,6 +27,7 @@
> 
> import org.eclipse.core.runtime.IPath;
> import org.eclipse.core.runtime.Platform;
>+import org.eclipse.hyades.execution.recorder.local.appadapters.JNIWrapper;
> 
> /**
>  * @author mdunn
>@@ -57,6 +58,7 @@
> 	// below is for bugzilla 177396 mdd
> 	public final int VISTA_ADMIN_ERROR = -8;
> 	public final int WINDOWS_ADMIN_ERROR = -8;
>+	public final int BROWSER_IN_USE_ERROR = -9;
> 	// bugzilla 79219 mdd
> 	private String sslProxyAddr = "";
> 	private String sslProxyPort = "";
>@@ -66,8 +68,18 @@
> 	private String proxyOverrideString = "";
> 	private String autoConfigURLString = "";
> 	
>+	private boolean bUseNativeRegistryInterface = false;
>+	private JNIWrapper jniWrapper = null;	
>+	
> 	public RecorderRegistryInfo() {
>-		StringBuffer inputFileContents = getRegistryInfo();
>+		StringBuffer inputFileContents = new StringBuffer();
>+		// return of false indicates fatal error
>+		if (checkOSVersion(inputFileContents) == true){
>+			if (bUseNativeRegistryInterface)
>+				getRegistryInfoUsingNativeAPI(inputFileContents);
>+			else
>+				getRegistryInfo(inputFileContents);
>+		}
> 		// below is for bugzilla 177396 mdd
> 		String checkVistaError=inputFileContents.toString();
> 		if (checkVistaError.equalsIgnoreCase("VISTA_ADMIN_ERROR")) {
>@@ -78,6 +90,10 @@
> 			setBadProxySettings(true);
> 			setProxyError(WINDOWS_ADMIN_ERROR);
> 		}
>+		else if (checkVistaError.equalsIgnoreCase("BROWSER_IN_USE_ERROR")) {
>+			setBadProxySettings(true);
>+			setProxyError(BROWSER_IN_USE_ERROR);
>+		}		
> 		else {
> 			boolean isEnabled = checkProxyEnabled(inputFileContents);
> 			setProxyEnabled(isEnabled);
>@@ -115,8 +131,38 @@
> 			}
> 		}
> 	}
>-
>-	private StringBuffer getRegistryInfo()
>+	
>+	private boolean checkOSVersion(StringBuffer inputFileContents){
>+		String currentOS = Platform.getOS();
>+		if (currentOS.equals("win32")) {
>+			String myVersion = System.getProperty("os.version");
>+			if (myVersion.startsWith("6")) {
>+				try{
>+					// Bugilla 168597, use native registry calls 
>+					// instead of displaying an error message
>+					jniWrapper = new JNIWrapper();
>+					if (jniWrapper.isProcessRunningElevated() == false){
>+						bUseNativeRegistryInterface = true;
>+						if (jniWrapper.isBrowserRunning() == true){
>+							inputFileContents.append("BROWSER_IN_USE_ERROR");
>+							return false;
>+						}
>+					}
>+				}
>+				// so, if we can't load our DLL, we will throw the old
>+				// error message out so the user can perform a recording by
>+				// running eclipse using "Run as Adminstrator
>+				// this should never happen 
>+				catch (UnsatisfiedLinkError e2){
>+					inputFileContents.append("VISTA_ADMIN_ERROR");
>+					return false;
>+				}
>+			}
>+		}
>+		return true;
>+	}
>+	
>+	private void getRegistryInfo(StringBuffer inputFileContents)
> 	{
> 		String originalSettingsFileName = "newSettingsFile.tmp";
> 		String originalSettingsFilePath = "";
>@@ -127,7 +173,6 @@
> 		String getOriginalInfoCommandLine = "regedit /e "+"\"" + originalSettingsFilePath+"\"" + " \"HKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\CurrentVersion\\Internet Settings\"";//$NON-NLS-1$//$NON-NLS-2$
> 		InputStreamReader inputReader=null;
> 		File file = null;
>-		StringBuffer inputFileContents = new StringBuffer();
> 		try
> 		{
> 			try {
>@@ -154,13 +199,22 @@
> 			if (currentOS.equals("win32")) {
> 				String myVersion = System.getProperty("os.version");
> 				if (myVersion.startsWith("6")) {
>-					inputFileContents.append("VISTA_ADMIN_ERROR");
>+					try{
>+						// Bugilla 168597, use native registry calls 
>+						// instead of displaying an error message
>+						jniWrapper = new JNIWrapper();
>+						bUseNativeRegistryInterface = true;
>+						
>+					}
>+					catch (UnsatisfiedLinkError e2){
>+						inputFileContents.append("VISTA_ADMIN_ERROR");
>+					}
> 				}
> 				else {
> 					inputFileContents.append("WINDOWS_ADMIN_ERROR");
>+					e.printStackTrace();					
> 				}
> 			}
>-			e.printStackTrace();
> 						
> 		} 
> 
>@@ -181,8 +235,29 @@
> 			if (file.exists())
> 				file.delete();
> 		}
>-		return inputFileContents;
>+		return;
>+	}
>+	
>+	// added for Bugilla 168597
>+	private void getRegistryInfoUsingNativeAPI(StringBuffer inputFileContents){
>+		// fire up an instance of the JNI layer to start using native code
>+		AddSettingToBuffer(jniWrapper, inputFileContents, "ProxyEnable");
>+		AddSettingToBuffer(jniWrapper, inputFileContents, "AutoConfigURL");
>+		AddSettingToBuffer(jniWrapper, inputFileContents, "ProxyServer");
>+		AddSettingToBuffer(jniWrapper, inputFileContents, "ProxyOverride");
>+
>+		return;
>+	}
>+	
>+	private void AddSettingToBuffer(JNIWrapper jniWrapper, StringBuffer inputFileContents, String name){
>+		String setting = jniWrapper.getInternetSetting(name);
>+		if (setting != null  && setting.length() > 0){
>+			inputFileContents.append("\"" + name + "\"=" + setting + "\r\n");
>+		}
>+		return;
> 	}
>+			
>+	
> 	private boolean checkProxyEnabled(StringBuffer inputBuffer) 
> 	{
> 			boolean comparesOK = false;

Actions: View

Attachments on bug 168597: 76930 | 76931 | 80259 | 80260 | 80261 | 80262 | 80270 | 80900 | 80901 | 80902