Attachment 79301 Details for Bug 204842 – Register programmatic actions as ActionHandlers v01

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Register programmatic actions as ActionHandlers v01

subactionbars-v01.txt (text/plain), 1.23 KB, created by Paul Webster

on 2007-09-27 13:44:36 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Webster

Created: 2007-09-27 13:44:36 EDT

Size: 1.23 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/SubActionBars.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/SubActionBars.java,v
>retrieving revision 1.33
>diff -u -r1.33 SubActionBars.java
>--- Eclipse UI/org/eclipse/ui/SubActionBars.java	22 Apr 2007 15:27:52 -0000	1.33
>+++ Eclipse UI/org/eclipse/ui/SubActionBars.java	27 Sep 2007 17:43:02 -0000
>@@ -487,9 +487,12 @@
> 
> 			// Add a mapping from this action id to the command id.
> 			if (serviceLocator != null) {
>-				final IActionCommandMappingService mappingService = (IActionCommandMappingService) serviceLocator
>-						.getService(IActionCommandMappingService.class);
>-				final String commandId = mappingService.getCommandId(actionID);
>+				String commandId = handler.getActionDefinitionId();
>+				if (commandId == null) {
>+					final IActionCommandMappingService mappingService = (IActionCommandMappingService) serviceLocator
>+							.getService(IActionCommandMappingService.class);
>+					commandId = mappingService.getCommandId(actionID);
>+				}
> 
> 				// Update the handler activations.
> 				final IHandlerService service = (IHandlerService) serviceLocator

Actions: View | Diff

Attachments on bug 204842: 79301