Attachment 78853 Details for Bug 35358 – Patch to change the ActionFactory class to create WorkbenchCommandAction.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to change the ActionFactory class to create WorkbenchCommandAction.

refresh-action-patch.txt (text/plain), 3.56 KB, created by Remy Suen

on 2007-09-20 10:37:41 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Remy Suen

Created: 2007-09-20 10:37:41 EDT

Size: 3.56 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/actions/ActionFactory.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/actions/ActionFactory.java,v
>retrieving revision 1.52
>diff -u -r1.52 ActionFactory.java
>--- Eclipse UI/org/eclipse/ui/actions/ActionFactory.java	17 Apr 2007 12:06:16 -0000	1.52
>+++ Eclipse UI/org/eclipse/ui/actions/ActionFactory.java	20 Sep 2007 14:35:11 -0000
>@@ -48,6 +48,7 @@
> import org.eclipse.ui.internal.actions.HelpSearchAction;
> import org.eclipse.ui.internal.actions.NewEditorAction;
> import org.eclipse.ui.internal.actions.OpenPerspectiveDialogAction;
>+import org.eclipse.ui.internal.commands.ICommandImageService;
> import org.eclipse.ui.services.IServiceLocator;
> 
> /**
>@@ -1119,10 +1120,17 @@
>             if (window == null) {
>                 throw new IllegalArgumentException();
>             }
>-            RetargetAction action = new RetargetAction(getId(),WorkbenchMessages.Workbench_refresh);
>-            action.setToolTipText(WorkbenchMessages.Workbench_refreshToolTip); 
>-            window.getPartService().addPartListener(action);
>-            action.setActionDefinitionId("org.eclipse.ui.file.refresh"); //$NON-NLS-1$
>+
>+            WorkbenchCommandAction action=new WorkbenchCommandAction("org.eclipse.ui.file.refresh", window); //$NON-NLS-1$
>+            action.setText(WorkbenchMessages.Workbench_refresh);
>+            action.setToolTipText(WorkbenchMessages.Workbench_refreshToolTip);  
>+            action.setId(getId());
>+            
>+            ICommandImageService service = (ICommandImageService) window.getService(ICommandImageService.class);
>+            action.setImageDescriptor(service.getImageDescriptor("org.eclipse.ui.file.refresh", ICommandImageService.TYPE_DEFAULT)); //$NON-NLS-1$
>+            action.setDisabledImageDescriptor(service.getImageDescriptor("org.eclipes.ui.file.refresh", ICommandImageService.TYPE_DISABLED)); //$NON-NLS-1$
>+            action.setDisabledImageDescriptor(service.getImageDescriptor("org.eclipes.ui.file.refresh", ICommandImageService.TYPE_HOVER)); //$NON-NLS-1$
>+            
>             return action;
>         }
>     };
>#P org.eclipse.ui
>Index: plugin.xml
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui/plugin.xml,v
>retrieving revision 1.397
>diff -u -r1.397 plugin.xml
>--- plugin.xml	13 Sep 2007 12:27:25 -0000	1.397
>+++ plugin.xml	20 Sep 2007 14:35:12 -0000
>@@ -1096,6 +1096,9 @@
>       <image
>             commandId="org.eclipse.ui.file.saveAs"
>             icon="$nl$/icons/full/etool16/saveas_edit.gif" />
>+      <image
>+            commandId="org.eclipse.ui.file.refresh"
>+            icon="$nl$/icons/full/elcl16/refresh_nav.gif" />
>    </extension>
>    
>    <extension
>Index: icons/full/elcl16/refresh_nav.gif
>===================================================================
>RCS file: icons/full/elcl16/refresh_nav.gif
>diff -N icons/full/elcl16/refresh_nav.gif
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ icons/full/elcl16/refresh_nav.gif	1 Jan 1970 00:00:00 -0000
>@@ -0,0 +1,4 @@
>+GIF89aÕýýþÍÓàô÷ýòõû÷ùýúûýùúüñõüÞèøäìùíòúõøýÜç÷áêøêðùòöüøúýæîùðõûó÷üõøûùûý÷ùûûüýüýýûüüÙÛ×?þýï?ûð´åâÏ¦¡¢½¯x´ª}¯¦?«¤ÇµqÅ´sÂ²u¹¬zûÞùÍ_Ê´zàÈ?Ô²hÔ²iÚ½|½Õ²i¶|¶}rrs¬r¦kÿÿÿ!ù;,?À?pH,OÈ$Ò(P(ìÄÉ266CekëB¡¸b¯Ô?Æú¸kÂ`>s¬Üm«Hþ*E:::-
>+
>+$C-;-%B-2;V¡¢&B`Va	ª«!5n,4
>+µµ"87,6¿À:ÆÇEÎÏÏLÒBA;

Actions: View | Diff

Attachments on bug 35358: 78853