Attachment 78400 Details for Bug 167866 – proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] proposed patch

clipboard.txt (text/plain), 3.60 KB, created by Eugene Kuleshov

on 2007-09-13 23:07:35 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eugene Kuleshov

Created: 2007-09-13 23:07:35 EDT

Size: 3.60 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java,v
>retrieving revision 1.225
>diff -u -r1.225 AbstractRepositoryTaskEditor.java
>--- src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java	14 Sep 2007 01:11:49 -0000	1.225
>+++ src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java	14 Sep 2007 03:05:12 -0000
>@@ -281,7 +281,7 @@
> 
> 	private Section commentsSection;
> 
>-	private Color colorIncoming;
>+	protected Color colorIncoming;
> 
> 	private boolean hasAttributeChanges = false;
> 
>#P org.eclipse.mylyn.bugzilla.ui
>Index: src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java,v
>retrieving revision 1.79
>diff -u -r1.79 BugzillaTaskEditor.java
>--- src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java	22 Aug 2007 20:50:02 -0000	1.79
>+++ src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java	14 Sep 2007 03:05:13 -0000
>@@ -20,6 +20,9 @@
> import org.eclipse.jface.dialogs.Dialog;
> import org.eclipse.jface.dialogs.MessageDialog;
> import org.eclipse.jface.layout.GridDataFactory;
>+import org.eclipse.jface.text.ITextListener;
>+import org.eclipse.jface.text.TextEvent;
>+import org.eclipse.jface.text.TextViewer;
> import org.eclipse.mylyn.internal.bugzilla.core.BugzillaCorePlugin;
> import org.eclipse.mylyn.internal.bugzilla.core.BugzillaReportElement;
> import org.eclipse.mylyn.internal.bugzilla.core.IBugzillaConstants;
>@@ -37,6 +40,7 @@
> import org.eclipse.mylyn.tasks.ui.editors.TaskEditor;
> import org.eclipse.mylyn.tasks.ui.search.SearchHitCollector;
> import org.eclipse.swt.SWT;
>+import org.eclipse.swt.custom.StyledText;
> import org.eclipse.swt.events.ModifyEvent;
> import org.eclipse.swt.events.ModifyListener;
> import org.eclipse.swt.events.SelectionAdapter;
>@@ -166,8 +170,31 @@
> 		if (attribute != null && !attribute.isReadOnly()) {
> 			Label label = createLabel(composite, attribute);
> 			GridDataFactory.fillDefaults().align(SWT.RIGHT, SWT.CENTER).applyTo(label);
>-			Text urlField = createTextField(composite, attribute, SWT.FLAT);
>-			GridDataFactory.fillDefaults().hint(135, SWT.DEFAULT).applyTo(urlField);
>+			
>+			TextViewer urlTextViewer = addTextEditor(repository, composite, attribute.getValue(), //
>+					false, SWT.FLAT | SWT.SINGLE);
>+			final StyledText urlText = urlTextViewer.getTextWidget();
>+			urlText.setData(FormToolkit.KEY_DRAW_BORDER, FormToolkit.TEXT_BORDER);
>+			urlText.setIndent(2);
>+
>+			final RepositoryTaskAttribute urlAttribute = attribute;
>+			
>+			urlTextViewer.setEditable(true);
>+			urlTextViewer.addTextListener(new ITextListener() {
>+				public void textChanged(TextEvent event) {
>+					String newValue = urlText.getText();
>+					if (!newValue.equals(urlAttribute.getValue())) {
>+						urlAttribute.setValue(newValue);
>+						attributeChanged(urlAttribute);
>+					}
>+				}
>+			});
>+			
>+			GridDataFactory.fillDefaults().hint(135, SWT.DEFAULT).applyTo(urlText);
>+
>+			if (hasChanged(attribute)) {
>+				urlText.setBackground(colorIncoming);
>+			}
> 		}
> 
> 		attribute = this.taskData.getAttribute(BugzillaReportElement.STATUS_WHITEBOARD.getKeyString());

Actions: View | Diff

Attachments on bug 167866: 78400 | 78401 | 79842 | 79843 | 79954