Attachment 78243 Details for Bug 202064 – Session Comments

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Session Comments

20070912-1-SessionComments.patch (text/plain), 1.40 KB, created by Simon Mc Duff

on 2007-09-12 21:06:19 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Mc Duff

Created: 2007-09-12 21:06:19 EDT

Size: 1.40 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.emf.cdo.server
>Index: src/org/eclipse/emf/cdo/internal/server/Session.java
>===================================================================
>RCS file: /cvsroot/modeling/org.eclipse.emf/org.eclipse.emf.cdo/plugins/org.eclipse.emf.cdo.server/src/org/eclipse/emf/cdo/internal/server/Session.java,v
>retrieving revision 1.22
>diff -u -r1.22 Session.java
>--- src/org/eclipse/emf/cdo/internal/server/Session.java	10 Sep 2007 09:48:46 -0000	1.22
>+++ src/org/eclipse/emf/cdo/internal/server/Session.java	13 Sep 2007 01:02:45 -0000
>@@ -188,6 +188,9 @@
> 
>   /**
>    * TODO I can't see how recursion is controlled/limited
>+   * TODO Should it collect revisions for isMany relationship as well ? 
>+   *      In this case we will have to serialize CDOViewImpl.loadRevisionCollectionChunkSize 
>+   *      or CDOFetchRuleManager.getLoadRevisionCollectionChunkSize ?
>    */
>   public void collectContainedRevisions(CDORevisionImpl revision, int referenceChunk, Set<CDOID> revisions,
>       List<CDORevisionImpl> additionalRevisions)
>@@ -209,7 +212,6 @@
>             CDORevisionImpl containedRevision = revisionManager.getRevision(id, referenceChunk);
>             revisions.add(id);
>             additionalRevisions.add(containedRevision);
>-
>             collectContainedRevisions(containedRevision, referenceChunk, revisions, additionalRevisions);
>           }
>         }

Actions: View | Diff

Attachments on bug 202064: 77860 | 77861 | 77950 | 77969 | 78135 | 78236 | 78242 | 78243 | 78395