Attachment 78236 Details for Bug 202064 – FIX toDO

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] FIX toDO

20070912-Analyzer.patch (text/plain), 2.48 KB, created by Simon Mc Duff

on 2007-09-12 18:20:51 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Mc Duff

Created: 2007-09-12 18:20:51 EDT

Size: 2.48 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.emf.cdo
>Index: src/org/eclipse/emf/internal/cdo/analyzer/CDOClusterOfFetchRule.java
>===================================================================
>RCS file: /cvsroot/modeling/org.eclipse.emf/org.eclipse.emf.cdo/plugins/org.eclipse.emf.cdo/src/org/eclipse/emf/internal/cdo/analyzer/CDOClusterOfFetchRule.java,v
>retrieving revision 1.2
>diff -u -r1.2 CDOClusterOfFetchRule.java
>--- src/org/eclipse/emf/internal/cdo/analyzer/CDOClusterOfFetchRule.java	12 Sep 2007 15:33:45 -0000	1.2
>+++ src/org/eclipse/emf/internal/cdo/analyzer/CDOClusterOfFetchRule.java	12 Sep 2007 22:19:51 -0000
>@@ -52,8 +52,7 @@
>   @Override
>   public int hashCode()
>   {
>-    // TODO Missing "rootClass.hashCode() ^ " or intention?
>-    return rootFeature.hashCode();
>+    return rootFeature.hashCode() ^ rootClass.hashCode();
>   }
> 
>   @Override
>Index: src/org/eclipse/emf/internal/cdo/analyzer/CDOAbstractFeatureRuleAnalyzer.java
>===================================================================
>RCS file: /cvsroot/modeling/org.eclipse.emf/org.eclipse.emf.cdo/plugins/org.eclipse.emf.cdo/src/org/eclipse/emf/internal/cdo/analyzer/CDOAbstractFeatureRuleAnalyzer.java,v
>retrieving revision 1.1
>diff -u -r1.1 CDOAbstractFeatureRuleAnalyzer.java
>--- src/org/eclipse/emf/internal/cdo/analyzer/CDOAbstractFeatureRuleAnalyzer.java	12 Sep 2007 15:33:45 -0000	1.1
>+++ src/org/eclipse/emf/internal/cdo/analyzer/CDOAbstractFeatureRuleAnalyzer.java	12 Sep 2007 22:19:51 -0000
>@@ -39,9 +39,6 @@
> 
>   protected int loadRevisionCollectionChunkSize;
> 
>-  /**
>-   * TODO Can didFetch be derived from fetchCount?
>-   */
>   private boolean didFetch;
> 
>   private int fetchCount = 0;
>Index: src/org/eclipse/emf/internal/cdo/analyzer/CDOFetchFeatureInfo.java
>===================================================================
>RCS file: /cvsroot/modeling/org.eclipse.emf/org.eclipse.emf.cdo/plugins/org.eclipse.emf.cdo/src/org/eclipse/emf/internal/cdo/analyzer/CDOFetchFeatureInfo.java,v
>retrieving revision 1.2
>diff -u -r1.2 CDOFetchFeatureInfo.java
>--- src/org/eclipse/emf/internal/cdo/analyzer/CDOFetchFeatureInfo.java	12 Sep 2007 15:33:45 -0000	1.2
>+++ src/org/eclipse/emf/internal/cdo/analyzer/CDOFetchFeatureInfo.java	12 Sep 2007 22:19:51 -0000
>@@ -104,8 +104,7 @@
>   @Override
>   public int hashCode()
>   {
>-    // TODO Missing "cdoClass.hashCode() ^ " or intention?
>-    return cdoFeature.hashCode();
>+    return cdoClass.hashCode()  ^ cdoFeature.hashCode();
>   }
> 
>   @Override

Actions: View | Diff

Attachments on bug 202064: 77860 | 77861 | 77950 | 77969 | 78135 | 78236 | 78242 | 78243 | 78395