Attachment 78081 Details for Bug 202095 – Updated patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Updated patch

patch.txt (text/plain), 1.54 KB, created by John Arthorne

on 2007-09-11 13:17:07 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: John Arthorne

Created: 2007-09-11 13:17:07 EDT

Size: 1.54 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.core.resources
>Index: src/org/eclipse/core/internal/resources/PathVariableManager.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/PathVariableManager.java,v
>retrieving revision 1.30
>diff -u -r1.30 PathVariableManager.java
>--- src/org/eclipse/core/internal/resources/PathVariableManager.java	22 Jun 2006 17:06:08 -0000	1.30
>+++ src/org/eclipse/core/internal/resources/PathVariableManager.java	11 Sep 2007 17:19:08 -0000
>@@ -14,6 +14,7 @@
> import java.util.*;
> import org.eclipse.core.filesystem.URIUtil;
> import org.eclipse.core.internal.events.PathVariableChangeEvent;
>+import org.eclipse.core.internal.utils.FileUtil;
> import org.eclipse.core.internal.utils.Messages;
> import org.eclipse.core.resources.*;
> import org.eclipse.core.runtime.*;
>@@ -184,9 +185,9 @@
> 	 */
> 	public void setValue(String varName, IPath newValue) throws CoreException {
> 		checkIsValidName(varName);
>-		//if the location doesn't have a device, see if the OS will assign one
>-		if (newValue != null && newValue.isAbsolute() && newValue.getDevice() == null)
>-			newValue = new Path(newValue.toFile().getAbsolutePath());
>+		//convert path value to canonical form
>+		if (newValue != null && newValue.isAbsolute())
>+			newValue = FileUtil.canonicalPath(newValue);
> 		checkIsValidValue(newValue);
> 		int eventType;
> 		// read previous value and set new value atomically in order to generate the right event

Actions: View | Diff

Attachments on bug 202095: 78058 | 78081 | 78178