Attachment 77623 Details for Bug 26873 – Patch to fix hyperlink behaviour

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to fix hyperlink behaviour

26873_bug_fix_patch.txt (text/plain), 1.37 KB, created by Nobody - feel free to take it

on 2007-09-04 04:27:05 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nobody - feel free to take it

Created: 2007-09-04 04:27:05 EDT

Size: 1.37 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface.text
>Index: src/org/eclipse/jface/text/hyperlink/HyperlinkManager.java
>===================================================================
>RCS file: 
>/cvsroot/eclipse/org.eclipse.jface.text/src/org/eclipse/jface/text/hyperlink/HyperlinkManager.java,v
>retrieving revision 1.18
>diff -u -r1.18 HyperlinkManager.java
>--- src/org/eclipse/jface/text/hyperlink/HyperlinkManager.java	4 Jun 2007 
>15:16:51 -0000	1.18
>+++ src/org/eclipse/jface/text/hyperlink/HyperlinkManager.java	3 Sep 2007 
>18:45:06 -0000
>@@ -364,18 +364,16 @@
>		fActive= true;
>		fActiveHyperlinkStateMask= event.keyCode;
>
>-//			removed for #25871 (hyperlinks could interact with typing)
>-//
>-//			ITextViewer viewer= getSourceViewer();
>-//			if (viewer == null)
>-//				return;
>-//
>-//			IRegion region= getCurrentTextRegion(viewer);
>-//			if (region == null)
>-//				return;
>-//
>-//			highlightRegion(viewer, region);
>-//			activateCursor(viewer);
>+		// Simple fix for bug : 26873
>+		// Check for available hyperlinks when a registered state mask has been 
>detected
>+		// and display the results (if any).
>+		fActiveHyperlinks= findHyperlinks();
>+		if (fActiveHyperlinks == null || fActiveHyperlinks.length == 0) {
>+			fHyperlinkPresenter.hideHyperlinks();
>+			return;
>+		}
>+
>+		fHyperlinkPresenter.showHyperlinks(fActiveHyperlinks);
>	}
>
>	/*
>

Actions: View | Diff

Attachments on bug 26873: 77623 | 79098