Attachment 77612 Details for Bug 202109 – Workaround, respect getData() != null instead of IStatus.OK, override VMElementsUpdate.done() to set elements regardless of count

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Workaround, respect getData() != null instead of IStatus.OK, override VMElementsUpdate.done() to set elements regardless of count

202109.txt (text/plain), 3.19 KB, created by Ted Williams

on 2007-09-04 00:04:02 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ted Williams

Created: 2007-09-04 00:04:02 EDT

Size: 3.19 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.dd.dsf.ui
>Index: src/org/eclipse/dd/dsf/ui/viewmodel/dm/AbstractDMVMLayoutNode.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.dsf.ui/src/org/eclipse/dd/dsf/ui/viewmodel/dm/AbstractDMVMLayoutNode.java,v
>retrieving revision 1.12
>diff -u -r1.12 AbstractDMVMLayoutNode.java
>--- src/org/eclipse/dd/dsf/ui/viewmodel/dm/AbstractDMVMLayoutNode.java	14 Jul 2007 03:04:58 -0000	1.12
>+++ src/org/eclipse/dd/dsf/ui/viewmodel/dm/AbstractDMVMLayoutNode.java	4 Sep 2007 03:59:14 -0000
>@@ -504,7 +504,7 @@
>     protected void fillUpdateWithVMCs(IChildrenUpdate update, IDMContext<V>[] dmcs) {
>         int startIdx = update.getOffset() != -1 ? update.getOffset() : 0;
>         int endIdx = update.getLength() != -1 ? startIdx + update.getLength() : dmcs.length;
>-        for (int i = startIdx; i < endIdx; i++) {
>+        for (int i = startIdx; i < endIdx && i < dmcs.length; i++) {
>             update.setChild(createVMContext(dmcs[i]), i);
>         }
>     }
>Index: src/org/eclipse/dd/dsf/ui/viewmodel/update/VMCache.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.dsf.ui/src/org/eclipse/dd/dsf/ui/viewmodel/update/VMCache.java,v
>retrieving revision 1.11
>diff -u -r1.11 VMCache.java
>--- src/org/eclipse/dd/dsf/ui/viewmodel/update/VMCache.java	14 Aug 2007 23:29:33 -0000	1.11
>+++ src/org/eclipse/dd/dsf/ui/viewmodel/update/VMCache.java	4 Sep 2007 03:59:14 -0000
>@@ -272,9 +272,9 @@
>     			@Override
>     			protected void handleCompleted()
>     			{
>-    				if(getStatus().isOK())
>+    				if(getData() != null)
>     				{
>-	    				for(int j = 0; j < update.getLength(); j++)
>+	    				for(int j = 0; j < getData().size(); j++)
> 	    				{
> 	    					if(isCacheWriteEnabled())
> 	    					{
>@@ -289,7 +289,16 @@
>     				}
>     				update.done();
> 				}
>-			});
>+			})
>+    		{
>+    			@Override
>+    		    public void done() {
>+    		        @SuppressWarnings("unchecked")
>+    		        DataRequestMonitor<List<Object>> rm = (DataRequestMonitor<List<Object>>)fRequestMonitor;
>+    		        rm.setData(fElements);
>+    		        super.done();
>+    		    }
>+    		};
>     	}
> 
>     	return updates;
>Index: src/org/eclipse/dd/dsf/ui/viewmodel/VMElementsUpdate.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.dsf.ui/src/org/eclipse/dd/dsf/ui/viewmodel/VMElementsUpdate.java,v
>retrieving revision 1.3
>diff -u -r1.3 VMElementsUpdate.java
>--- src/org/eclipse/dd/dsf/ui/viewmodel/VMElementsUpdate.java	17 Jul 2007 00:11:09 -0000	1.3
>+++ src/org/eclipse/dd/dsf/ui/viewmodel/VMElementsUpdate.java	4 Sep 2007 03:59:14 -0000
>@@ -29,7 +29,7 @@
> public class VMElementsUpdate extends VMViewerUpdate implements IChildrenUpdate {
>     private final int fOffset;
>     private final int fLength;
>-    private final List<Object> fElements;
>+    protected final List<Object> fElements;
>     
>     public VMElementsUpdate(IChildrenUpdate clientUpdate, int offset, int length, DataRequestMonitor<List<Object>> requestMonitor) {
>         super(clientUpdate, requestMonitor);

Flags:

cdtdoug: iplog-

Actions: View | Diff

Attachments on bug 202109: 77612