Attachment 77411 Details for Bug 201539 – fix. set right end tag and exception handling,

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix. set right end tag and exception handling,

patch50.txt (text/plain), 2.32 KB, created by Alexander N. Alexeev

on 2007-08-30 16:45:07 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexander N. Alexeev

Created: 2007-08-30 16:45:07 EDT

Size: 2.32 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.tptp.platform.jvmti.client
>Index: src/org/eclipse/tptp/platform/jvmti/client/internal/launcher/TIDelegateHelper.java
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.tptp.platform.jvmti.client/src/org/eclipse/tptp/platform/jvmti/client/internal/launcher/TIDelegateHelper.java,v
>retrieving revision 1.63
>diff -u -r1.63 TIDelegateHelper.java
>--- src/org/eclipse/tptp/platform/jvmti/client/internal/launcher/TIDelegateHelper.java	24 Aug 2007 17:38:11 -0000	1.63
>+++ src/org/eclipse/tptp/platform/jvmti/client/internal/launcher/TIDelegateHelper.java	30 Aug 2007 20:45:15 -0000
>@@ -711,7 +711,7 @@
>     			tiAgent.run();
>     		
>     		if (!isEnableDataCollection) {
>-    			setPausedState(agentProxy);
>+    			setPausedState(tiAgentProxy);
>     		}		
>           	          	
> 			return trcAgentProxy;
>@@ -1214,15 +1214,16 @@
> 
> 	public void sendEnableDataCollection(ILaunchConfiguration configuration, 
> 			ICollector tiAgent) {
>-		String cmd = new String("<EnableDataCollection iid=\"org.eclipse.tptp.jvmti\"></enableDataCollection>");
>+		Exception error = null;
>+		String cmd = new String("<EnableDataCollection iid=\"org.eclipse.tptp.jvmti\"></EnableDataCollection>");
> 		boolean isEnableDataCollection = true;
> 		
> 		if (configuration != null) {
> 			try {
> 				isEnableDataCollection = configuration == null ? true : configuration.getAttribute(IProfileLaunchConfigurationConstants.ATTR_AUTO_MONITORING, true);
> 			} catch (CoreException e) {
>-				// TODO Auto-generated catch block
>-				e.printStackTrace();
>+				LauncherUtility.openErrorWithDetail(LauncherMessages.LAUNCHER_COMMON_ERROR_TITLE, TIMessages.ERROR_TI_AGENT_FILTERS, e);
>+				return;
> 			}
> 		}
> 		
>@@ -1230,12 +1231,14 @@
> 			try {
> 				tiAgent.sendCommand(cmd, NOOP_COMMAND_HANDLER);
> 			} catch (InactiveAgentException e) {
>-				// TODO Auto-generated catch block
>-				e.printStackTrace();
>+				error = e;
> 			} catch (NotConnectedException e) {
>-				// TODO Auto-generated catch block
>-				e.printStackTrace();
>-			}			
>+				error = e;
>+			}
>+			if (error != null) {
>+				LauncherUtility.openErrorWithDetail(LauncherMessages.LAUNCHER_COMMON_ERROR_TITLE, TIMessages.ERROR_TI_AGENT_FILTERS, error);
>+				return;
>+			}
> 			return;
> 		}
>

Actions: View | Diff

Attachments on bug 201539: 77229 | 77410 | 77411