Attachment 77364 Details for Bug 65731 – Patch to not log anything per Daniel's comment #24.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to not log anything per Daniel's comment #24.

org.eclipse.ui.workbench-bug65731-no-error-with-missing-icon.txt (text/plain), 2.30 KB, created by Remy Suen

on 2007-08-30 07:00:09 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Remy Suen

Created: 2007-08-30 07:00:09 EDT

Size: 2.30 KB

patch

obsolete

>Index: Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistryReader.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistryReader.java,v
>retrieving revision 1.24
>diff -u -r1.24 EditorRegistryReader.java
>--- Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistryReader.java	27 Nov 2006 23:33:40 -0000	1.24
>+++ Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistryReader.java	30 Aug 2007 10:58:19 -0000
>@@ -70,14 +70,6 @@
>             logMissingAttribute(element, IWorkbenchRegistryConstants.ATT_NAME);
>             return true;
>         }
>-
>-        // Get editor icon (required field for internal editors)
>-        if (element.getAttribute(IWorkbenchRegistryConstants.ATT_ICON) == null) {
>-            if (getClassValue(element, IWorkbenchRegistryConstants.ATT_CLASS) != null) {
>-                logMissingAttribute(element, IWorkbenchRegistryConstants.ATT_ICON);
>-                return true;
>-            }
>-        }
>         
>         // Get target extensions (optional field)
>         String extensionsString = element.getAttribute(IWorkbenchRegistryConstants.ATT_EXTENSIONS);
>Index: Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java,v
>retrieving revision 1.22
>diff -u -r1.22 RegistryReader.java
>--- Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java	16 Mar 2007 18:00:34 -0000	1.22
>+++ Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java	30 Aug 2007 10:58:19 -0000
>@@ -53,7 +53,13 @@
>         StringBuffer buf = new StringBuffer();
>         buf
>                 .append("Plugin " + extension.getNamespace() + ", extension " + extension.getExtensionPointUniqueIdentifier());//$NON-NLS-2$//$NON-NLS-1$
>-        buf.append("\n" + text);//$NON-NLS-1$
>+        // look for an ID if available - this should help debugging
>+        String id = element.getAttribute("id"); //$NON-NLS-1$
>+        if (id != null) {
>+        	buf.append(", id "); //$NON-NLS-1$
>+        	buf.append(id);
>+        }
>+        buf.append(": " + text);//$NON-NLS-1$
>         WorkbenchPlugin.log(buf.toString());
>     }
>

Actions: View | Diff

Attachments on bug 65731: 13317 | 73841 | 73848 | 77364