Attachment 75210 Details for Bug 198410 – fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix

fix_198410.txt (text/plain), 1.61 KB, created by Benno Baumgartner

on 2007-08-02 07:46:46 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Benno Baumgartner

Created: 2007-08-02 07:46:46 EDT

Size: 1.61 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.ui
>Index: ui/org/eclipse/jdt/internal/ui/packageview/FileTransferDragAdapter.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/FileTransferDragAdapter.java,v
>retrieving revision 1.26
>diff -u -r1.26 FileTransferDragAdapter.java
>--- ui/org/eclipse/jdt/internal/ui/packageview/FileTransferDragAdapter.java	31 Jul 2007 15:10:34 -0000	1.26
>+++ ui/org/eclipse/jdt/internal/ui/packageview/FileTransferDragAdapter.java	2 Aug 2007 11:47:59 -0000
>@@ -58,10 +58,12 @@
> public class FileTransferDragAdapter extends DragSourceAdapter implements TransferDragSourceListener {
> 	
> 	private ISelectionProvider fProvider;
>+	private boolean fWasDataRequested;
> 	
> 	public FileTransferDragAdapter(ISelectionProvider provider) {
> 		fProvider= provider;
> 		Assert.isNotNull(fProvider);
>+		fWasDataRequested= false;
> 	}
> 
> 	public Transfer getTransfer() {
>@@ -70,6 +72,7 @@
> 	
> 	public void dragStart(DragSourceEvent event) {
> 		event.doit= isDragable(fProvider.getSelection());
>+		fWasDataRequested= false;
> 	}
> 	
> 	private boolean isDragable(ISelection s) {
>@@ -103,6 +106,7 @@
> 		}
> 		
> 		event.data= getResourceLocations(elements);
>+		fWasDataRequested= true;
> 	}
> 
> 	private static String[] getResourceLocations(List resources) {
>@@ -113,6 +117,9 @@
> 		if (!event.doit)
> 			return;
> 		
>+		if (!fWasDataRequested)
>+			return;
>+		
> 		if (event.detail == DND.DROP_MOVE) {
> 			// http://bugs.eclipse.org/bugs/show_bug.cgi?id=30543
> 			// handleDropMove(event);

Actions: View | Diff

Attachments on bug 198410: 75210