Attachment 73848 Details for Bug 65731 – patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch

patch-65731.txt (text/plain), 2.15 KB, created by Boris Bokowski

on 2007-07-16 10:10:10 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Boris Bokowski

Created: 2007-07-16 10:10:10 EDT

Size: 2.15 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistryReader.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistryReader.java,v
>retrieving revision 1.24
>diff -u -r1.24 EditorRegistryReader.java
>--- Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistryReader.java	27 Nov 2006 23:33:40 -0000	1.24
>+++ Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistryReader.java	16 Jul 2007 14:10:34 -0000
>@@ -75,7 +75,7 @@
>         if (element.getAttribute(IWorkbenchRegistryConstants.ATT_ICON) == null) {
>             if (getClassValue(element, IWorkbenchRegistryConstants.ATT_CLASS) != null) {
>                 logMissingAttribute(element, IWorkbenchRegistryConstants.ATT_ICON);
>-                return true;
>+                // Fix for bug 65731: continue even if there is no icon attribute 
>             }
>         }
>         
>Index: Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java,v
>retrieving revision 1.22
>diff -u -r1.22 RegistryReader.java
>--- Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java	16 Mar 2007 18:00:34 -0000	1.22
>+++ Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java	16 Jul 2007 14:10:34 -0000
>@@ -53,7 +53,13 @@
>         StringBuffer buf = new StringBuffer();
>         buf
>                 .append("Plugin " + extension.getNamespace() + ", extension " + extension.getExtensionPointUniqueIdentifier());//$NON-NLS-2$//$NON-NLS-1$
>-        buf.append("\n" + text);//$NON-NLS-1$
>+        // look for an ID if available - this should help debugging
>+        String id = element.getAttribute("id"); //$NON-NLS-1$
>+        if (id != null) {
>+        	buf.append(", id "); //$NON-NLS-1$
>+        	buf.append(id);
>+        }
>+        buf.append(": " + text);//$NON-NLS-1$
>         WorkbenchPlugin.log(buf.toString());
>     }
>

Flags:

daniel_megert: review-

Actions: View | Diff

Attachments on bug 65731: 13317 | 73841 | 73848 | 77364