Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
View | Details | Raw Unified | Return to bug 65731 | Differences between
and this patch

Collapse All | Expand All

(-)Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistryReader.java (-1 / +1 lines)
Lines 75-81 Link Here
75 
        if (element.getAttribute(IWorkbenchRegistryConstants.ATT_ICON) == null) {
 75 
        if (element.getAttribute(IWorkbenchRegistryConstants.ATT_ICON) == null) {
76 
            if (getClassValue(element, IWorkbenchRegistryConstants.ATT_CLASS) != null) {
 76 
            if (getClassValue(element, IWorkbenchRegistryConstants.ATT_CLASS) != null) {
77 
                logMissingAttribute(element, IWorkbenchRegistryConstants.ATT_ICON);
 77 
                logMissingAttribute(element, IWorkbenchRegistryConstants.ATT_ICON);
78 
                return true;
 78 
                // Fix for bug 65731: continue even if there is no icon attribute
79 
            }
 79 
            }
80 
        }
 80 
        }
81
81
(-)Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java (-1 / +7 lines)
Lines 53-59 Link Here
53 
        StringBuffer buf = new StringBuffer();
 53 
        StringBuffer buf = new StringBuffer();
54 
        buf
 54 
        buf
55 
                .append("Plugin " + extension.getNamespace() + ", extension " + extension.getExtensionPointUniqueIdentifier());//$NON-NLS-2$//$NON-NLS-1$
 55 
                .append("Plugin " + extension.getNamespace() + ", extension " + extension.getExtensionPointUniqueIdentifier());//$NON-NLS-2$//$NON-NLS-1$
56 
        buf.append("\n" + text);//$NON-NLS-1$
 56 
        // look for an ID if available - this should help debugging
57 
        String id = element.getAttribute("id"); //$NON-NLS-1$
58 
        if (id != null) {
59 
        	buf.append(", id "); //$NON-NLS-1$
60 
        	buf.append(id);
61 
        }
62 
        buf.append(": " + text);//$NON-NLS-1$
57 
        WorkbenchPlugin.log(buf.toString());
 63 
        WorkbenchPlugin.log(buf.toString());
58 
    }
 64 
    }
59 

          65
          

        






  

  Return to bug 65731