Attachment 72087 Details for Bug 190633 – Patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch

patch190633.txt (text/plain), 2.06 KB, created by Adam Archer

on 2007-06-21 16:37:22 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Adam Archer

Created: 2007-06-21 16:37:22 EDT

Size: 2.06 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.help.ui
>Index: src/org/eclipse/help/ui/internal/preferences/HelpContentPreferencePage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/preferences/HelpContentPreferencePage.java,v
>retrieving revision 1.4
>diff -u -r1.4 HelpContentPreferencePage.java
>--- src/org/eclipse/help/ui/internal/preferences/HelpContentPreferencePage.java	13 Sep 2006 21:12:46 -0000	1.4
>+++ src/org/eclipse/help/ui/internal/preferences/HelpContentPreferencePage.java	21 Jun 2007 20:30:11 -0000
>@@ -48,6 +48,9 @@
> 	private Button radio2;
> 	private Text portText;
> 	
>+	private final static String LRE = "\u202A";	 //$NON-NLS-1$
>+	private final static String PDF = "\u202C";	 //$NON-NLS-1$
>+	
> 	/*
> 	 * Listens for any change in the UI and checks for valid
> 	 * input and correct enablement.
>@@ -111,7 +114,11 @@
> 		Preferences prefs = HelpBasePlugin.getDefault().getPluginPreferences();
> 		prefs.setValue(IHelpBaseConstants.P_KEY_REMOTE_HELP_ON, checkbox.getSelection());
> 		prefs.setValue(IHelpBaseConstants.P_KEY_REMOTE_HELP_HOST, hostText.getText().trim());
>-		prefs.setValue(IHelpBaseConstants.P_KEY_REMOTE_HELP_PATH, pathText.getText().trim());
>+		String path = pathText.getText();
>+		int index = path.lastIndexOf(LRE);
>+		if (index != -1)
>+			path = path.substring(index+LRE.length(),path.indexOf(PDF)).trim();
>+		prefs.setValue(IHelpBaseConstants.P_KEY_REMOTE_HELP_PATH, path);
> 		prefs.setValue(IHelpBaseConstants.P_KEY_REMOTE_HELP_DEFAULT_PORT, radio1.getSelection());
> 		prefs.setValue(IHelpBaseConstants.P_KEY_REMOTE_HELP_PORT, portText.getText().trim());
> 		
>@@ -209,6 +216,8 @@
> 	private void setValues(boolean isOn, String host, String path, boolean useDefaultPort, int port) {
> 		checkbox.setSelection(isOn);
> 		hostText.setText(host);
>+		if (pathText.getOrientation() == SWT.RIGHT_TO_LEFT)
>+			path = LRE + path + PDF;
> 		pathText.setText(path);
> 		radio1.setSelection(useDefaultPort);
> 		radio2.setSelection(!useDefaultPort);

Actions: View | Diff

Attachments on bug 190633: 69847 | 70523 | 70524 | 71643 | 72087 | 73053