Attachment 70275 Details for Bug 190768 – Patch for SSE FileBufferModelManager

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch for SSE FileBufferModelManager

190768-sse.patch (text/plain), 1.79 KB, created by Nitin Dahyabhai

on 2007-06-06 01:11:52 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nitin Dahyabhai

Created: 2007-06-06 01:11:52 EDT

Size: 1.79 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.wst.sse.core
>Index: src/org/eclipse/wst/sse/core/internal/FileBufferModelManager.java
>===================================================================
>RCS file: /cvsroot/webtools/wst/components/sse/plugins/org.eclipse.wst.sse.core/src/org/eclipse/wst/sse/core/internal/FileBufferModelManager.java,v
>retrieving revision 1.35
>diff -u -r1.35 FileBufferModelManager.java
>--- src/org/eclipse/wst/sse/core/internal/FileBufferModelManager.java	24 May 2007 04:20:59 -0000	1.35
>+++ src/org/eclipse/wst/sse/core/internal/FileBufferModelManager.java	6 Jun 2007 05:09:02 -0000
>@@ -532,7 +532,22 @@
> 					info.locationKind = LocationKind.LOCATION;
> 					info.selfConnected = true;
> 				}
>-				model = getModel((IStructuredDocument) buffer.getDocument());
>+				/*
>+				 * Check the document type. Although returning null for
>+				 * unknown documents would be fair, try to get a model if
>+				 * the document is at least a valid type.
>+				 */
>+				IDocument bufferDocument = buffer.getDocument();
>+				if (bufferDocument instanceof IStructuredDocument) {
>+					model = getModel((IStructuredDocument) bufferDocument);
>+				}
>+				else {
>+					/*
>+					 * 190768 - Quick diff marks do not disappear in the
>+					 * vertical ruler of JavaScript editor
>+					 */
>+					bufferManager.disconnect(location, LocationKind.IFILE, getProgressMonitor());
>+				}
> 			}
> 		}
> 		catch (CoreException e) {
>@@ -586,6 +601,13 @@
> 					if (bufferDocument instanceof IStructuredDocument) {
> 						model = getModel((IStructuredDocument) bufferDocument);
> 					}
>+					else {
>+						/*
>+						 * 190768 - Quick diff marks do not disappear in the
>+						 * vertical ruler of JavaScript editor
>+						 */
>+						bufferManager.disconnect(location, LocationKind.IFILE, getProgressMonitor());
>+					}
> 				}
> 			}
> 		}

Actions: View | Diff

Attachments on bug 190768: 70275