Attachment 69545 Details for Bug 173752 – Fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix

173752_patch.txt (text/plain), 1.64 KB, created by Markus Keller

on 2007-05-31 12:16:31 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Markus Keller

Created: 2007-05-31 12:16:31 EDT

Size: 1.64 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/dialogs/AboutPluginsDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/AboutPluginsDialog.java,v
>retrieving revision 1.33
>diff -u -r1.33 AboutPluginsDialog.java
>--- Eclipse UI/org/eclipse/ui/internal/dialogs/AboutPluginsDialog.java	16 Mar 2007 18:00:32 -0000	1.33
>+++ Eclipse UI/org/eclipse/ui/internal/dialogs/AboutPluginsDialog.java	31 May 2007 16:15:28 -0000
>@@ -517,6 +517,12 @@
> 	 * @see org.eclipse.jface.viewers.ViewerComparator#compare(org.eclipse.jface.viewers.Viewer, java.lang.Object, java.lang.Object)
> 	 */
> 	public int compare(Viewer viewer, Object e1, Object e2) {
>+		if (sortColumn == 0 && e1 instanceof AboutBundleData && e2 instanceof AboutBundleData) {
>+			AboutBundleData d1= (AboutBundleData) e1;
>+			AboutBundleData d2= (AboutBundleData) e2;
>+			int diff= getSignedSortValue(d1) - getSignedSortValue(d2);
>+			return ascending ? diff : -diff;
>+		}
> 		if (viewer instanceof TableViewer) {
> 			TableViewer tableViewer = (TableViewer) viewer;
> 			IBaseLabelProvider baseLabel = tableViewer.getLabelProvider();
>@@ -533,6 +539,20 @@
> 	}
> 
> 	/**
>+	 * @param data
>+	 * @return a sort value depending on the signed state
>+	 */
>+	private int getSignedSortValue(AboutBundleData data) {
>+		if (! data.isSignedDetermined()) {
>+			return 0;
>+		} else if (data.isSigned()) {
>+			return 1;
>+		} else {
>+			return -1;
>+		}
>+	}
>+	
>+	/**
> 	 * @return Returns the sortColumn.
> 	 */
> 	public int getSortColumn() {

Actions: View | Diff

Attachments on bug 173752: 69545 | 86519 | 86829