Attachment 68794 Details for Bug 189168 – The patch to rethrow the original exception instead of eating it

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] The patch to rethrow the original exception instead of eating it

189168.txt (text/plain), 2.89 KB, created by Dejan Glozic

on 2007-05-25 12:25:07 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dejan Glozic

Created: 2007-05-25 12:25:07 EDT

Size: 2.89 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.update.core
>Index: src/org/eclipse/update/internal/core/messages.properties
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.update.core/src/org/eclipse/update/internal/core/messages.properties,v
>retrieving revision 1.102
>diff -u -r1.102 messages.properties
>--- src/org/eclipse/update/internal/core/messages.properties	22 May 2007 22:55:28 -0000	1.102
>+++ src/org/eclipse/update/internal/core/messages.properties	25 May 2007 16:23:34 -0000
>@@ -348,3 +348,4 @@
> FeatureExecutableContentProvider_UnableToRetriveArchiveContentRef = Unable to retreive archive content reference
> SiteCategory_other_label = Other
> SiteCategory_other_description = Features found under this category are either not categorized or their categories could not be found on server.
>+LocalSite_error_loading_config=Error while loading platform configuration
>Index: src/org/eclipse/update/internal/core/LocalSite.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.update.core/src/org/eclipse/update/internal/core/LocalSite.java,v
>retrieving revision 1.8
>diff -u -r1.8 LocalSite.java
>--- src/org/eclipse/update/internal/core/LocalSite.java	11 Apr 2006 16:37:57 -0000	1.8
>+++ src/org/eclipse/update/internal/core/LocalSite.java	25 May 2007 16:23:34 -0000
>@@ -18,6 +18,7 @@
> import org.eclipse.core.runtime.CoreException;
> import org.eclipse.core.runtime.IProgressMonitor;
> import org.eclipse.core.runtime.IStatus;
>+import org.eclipse.core.runtime.Status;
> import org.eclipse.osgi.util.NLS;
> import org.eclipse.update.configuration.IActivity;
> import org.eclipse.update.configuration.IInstallConfiguration;
>@@ -93,7 +94,10 @@
> 			new SiteLocalParser(platformConfig, localSite);
> 			return true;
> 		} catch (Exception exception) {
>-			return false;
>+			throw new CoreException(new Status(IStatus.ERROR, UpdateCore.getPlugin().getBundle().getSymbolicName(),
>+					IStatus.OK,
>+					Messages.LocalSite_error_loading_config, 
>+					exception));
> 		}
> 	}
> 
>Index: src/org/eclipse/update/internal/core/Messages.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.update.core/src/org/eclipse/update/internal/core/Messages.java,v
>retrieving revision 1.8
>diff -u -r1.8 Messages.java
>--- src/org/eclipse/update/internal/core/Messages.java	22 May 2007 22:55:28 -0000	1.8
>+++ src/org/eclipse/update/internal/core/Messages.java	25 May 2007 16:23:34 -0000
>@@ -49,6 +49,7 @@
> 	public static String InstallHandler_error;
> 	public static String InstallMonitor_DownloadSize;
> 	public static String InstallMonitor_DownloadSizeLong;
>+	public static String LocalSite_error_loading_config;
> 	public static String ProductProvider;
> 	public static String Reconciler_appNotFound;
> 	public static String JarContentReference_Unpacking;

Actions: View | Diff

Attachments on bug 189168: 68794