Attachment 68344 Details for Bug 128927 – Cleaner patch using the new 'getViewReference' method in Perspective

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Cleaner patch using the new 'getViewReference' method in Perspective

patch(128927) (text/plain), 1.11 KB, created by Eric Moffatt

on 2007-05-23 10:34:45 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Moffatt

Created: 2007-05-23 10:34:45 EDT

Size: 1.11 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/Perspective.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Perspective.java,v
>retrieving revision 1.160
>diff -u -r1.160 Perspective.java
>--- Eclipse UI/org/eclipse/ui/internal/Perspective.java	23 May 2007 13:39:36 -0000	1.160
>+++ Eclipse UI/org/eclipse/ui/internal/Perspective.java	23 May 2007 14:33:05 -0000
>@@ -1451,10 +1451,8 @@
>             viewID = ViewFactory.extractPrimaryId(viewID);
>         }
> 
>-        IViewReference viewRef = viewFactory.getView(viewID,
>-                secondaryId);
>-        WorkbenchPartReference ref = (WorkbenchPartReference) viewRef;
>-        if (ref == null) {
>+        IViewReference viewRef = getViewReference(viewID, secondaryId);
>+        if (viewRef == null) {
>             String key = ViewFactory.getKey(viewID, secondaryId);
>             WorkbenchPlugin
>                     .log("Could not create view: '" + key + "'."); //$NON-NLS-1$ //$NON-NLS-2$

Actions: View | Diff

Attachments on bug 128927: 66688 | 68344