Attachment 67922 Details for Bug 187826 – Patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch

patch.txt (text/plain), 2.51 KB, created by Thomas Schindl

on 2007-05-20 17:29:44 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Schindl

Created: 2007-05-20 17:29:44 EDT

Size: 2.51 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface
>Index: src/org/eclipse/jface/viewers/TableViewer.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/TableViewer.java,v
>retrieving revision 1.83
>diff -u -r1.83 TableViewer.java
>--- src/org/eclipse/jface/viewers/TableViewer.java	27 Apr 2007 04:27:20 -0000	1.83
>+++ src/org/eclipse/jface/viewers/TableViewer.java	20 May 2007 21:29:21 -0000
>@@ -9,7 +9,7 @@
>  *     IBM Corporation - initial API and implementation
>  *     Tom Schindl <tom.schindl@bestsolution.at> - concept of ViewerRow,
>  *                                                 fix for 159597, refactoring (bug 153993), 
>- *                                                 widget-independency (bug 154329)
>+ *                                                 widget-independency (bug 154329), fix for 187826
>  *******************************************************************************/
> 
> package org.eclipse.jface.viewers;
>@@ -314,6 +314,11 @@
> 			boolean reveal) {
> 		if (isBusy())
> 			return;
>+		
>+		if( isCellEditorActive() ) {
>+			cancelEditing();
>+		}
>+		
> 		preservingSelection(new Runnable() {
> 			public void run() {
> 				internalRefresh(element, updateLabels);
>Index: src/org/eclipse/jface/viewers/ColumnViewer.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/ColumnViewer.java,v
>retrieving revision 1.38
>diff -u -r1.38 ColumnViewer.java
>--- src/org/eclipse/jface/viewers/ColumnViewer.java	8 May 2007 19:02:54 -0000	1.38
>+++ src/org/eclipse/jface/viewers/ColumnViewer.java	20 May 2007 21:29:21 -0000
>@@ -8,7 +8,7 @@
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>  *     Tom Schindl <tom.schindl@bestsolution.at> - initial API and implementation; bug 153993
>- *												   fix in bug 163317, 151295, 167323, 167858, 184346
>+ *												   fix in bug 163317, 151295, 167323, 167858, 184346, 187826
>  *******************************************************************************/
> 
> package org.eclipse.jface.viewers;
>@@ -495,12 +495,22 @@
> 	public void refresh(Object element) {
> 		if (isBusy())
> 			return;
>+		
>+		if( isCellEditorActive() ) {
>+			cancelEditing();
>+		}
>+		
> 		super.refresh(element);
> 	}
> 	
> 	public void refresh(Object element, boolean updateLabels) {
> 		if (isBusy())
> 			return;
>+		
>+		if( isCellEditorActive() ) {
>+			cancelEditing();
>+		}
>+		
> 		super.refresh(element, updateLabels);
> 	}
>

Actions: View | Diff

Attachments on bug 187826: 67922