Attachment 67141 Details for Bug 183679 – patch to add busy cursor while opening

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch to add busy cursor while opening

patch-183679-rc1.txt (text/plain), 3.41 KB, created by Boris Bokowski

on 2007-05-14 17:19:28 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Boris Bokowski

Created: 2007-05-14 17:19:28 EDT

Size: 3.41 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/quickaccess/QuickAccessDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/QuickAccessDialog.java,v
>retrieving revision 1.8
>diff -u -r1.8 QuickAccessDialog.java
>--- Eclipse UI/org/eclipse/ui/internal/quickaccess/QuickAccessDialog.java	2 May 2007 20:42:48 -0000	1.8
>+++ Eclipse UI/org/eclipse/ui/internal/quickaccess/QuickAccessDialog.java	14 May 2007 21:13:14 -0000
>@@ -27,6 +27,7 @@
> import org.eclipse.jface.window.ToolTip;
> import org.eclipse.osgi.util.NLS;
> import org.eclipse.swt.SWT;
>+import org.eclipse.swt.custom.BusyIndicator;
> import org.eclipse.swt.events.ControlAdapter;
> import org.eclipse.swt.events.ControlEvent;
> import org.eclipse.swt.events.KeyAdapter;
>@@ -110,34 +111,40 @@
> 	/**
> 	 * @param parent
> 	 */
>-	QuickAccessDialog(IWorkbenchWindow window, Command invokingCommand) {
>+	QuickAccessDialog(IWorkbenchWindow window, final Command invokingCommand) {
> 		super(ProgressManagerUtil.getDefaultParent(), SWT.RESIZE, true, true,
> 				true, true, null,
> 				QuickAccessMessages.QuickAccess_StartTypingToFindMatches);
> 
> 		this.window = window;
>-		this.providers = new QuickAccessProvider[] {
>-				new PreviousPicksProvider(), new EditorProvider(),
>-				new ViewProvider(), new PerspectiveProvider(),
>-				new CommandProvider(), new ActionProvider(),
>-				new WizardProvider(), new PreferenceProvider(),
>-				new PropertiesProvider() };
>-		providers[0] = new PreviousPicksProvider();
>-		providerMap = new HashMap();
>-		for (int i = 0; i < providers.length; i++) {
>-			providerMap.put(providers[i].getId(), providers[i]);
>-		}
>-		restoreDialog();
>-		this.invokingCommand = invokingCommand;
>-		if (this.invokingCommand != null && !this.invokingCommand.isDefined()) {
>-			this.invokingCommand = null;
>-		} else {
>-			// Pre-fetch key sequence - do not change because scope will
>-			// change later.
>-			getInvokingCommandKeySequences();
>-		}
>-		// create early
>-		create();
>+		BusyIndicator.showWhile(window.getShell() == null ? null : window
>+				.getShell().getDisplay(), new Runnable() {
>+			public void run() {
>+				QuickAccessDialog.this.providers = new QuickAccessProvider[] {
>+						new PreviousPicksProvider(), new EditorProvider(),
>+						new ViewProvider(), new PerspectiveProvider(),
>+						new CommandProvider(), new ActionProvider(),
>+						new WizardProvider(), new PreferenceProvider(),
>+						new PropertiesProvider() };
>+				providers[0] = new PreviousPicksProvider();
>+				providerMap = new HashMap();
>+				for (int i = 0; i < providers.length; i++) {
>+					providerMap.put(providers[i].getId(), providers[i]);
>+				}
>+				restoreDialog();
>+				QuickAccessDialog.this.invokingCommand = invokingCommand;
>+				if (QuickAccessDialog.this.invokingCommand != null
>+						&& !QuickAccessDialog.this.invokingCommand.isDefined()) {
>+					QuickAccessDialog.this.invokingCommand = null;
>+				} else {
>+					// Pre-fetch key sequence - do not change because scope will
>+					// change later.
>+					getInvokingCommandKeySequences();
>+				}
>+				// create early
>+				create();
>+			}
>+		});
> 		// Ugly hack to avoid bug 184045. If this gets fixed, replace the
> 		// following code with a call to refresh("").
> 		getShell().getDisplay().asyncExec(new Runnable() {

Actions: View | Diff

Attachments on bug 183679: 64658 | 64813 | 67141