Attachment 66380 Details for Bug 170326 – patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch

170326_patch.txt (text/plain), 4.68 KB, created by Eugene Chan

on 2007-05-08 18:56:19 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eugene Chan

Created: 2007-05-08 18:56:19 EDT

Size: 4.68 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.tptp.platform.log.views
>Index: src/org/eclipse/tptp/platform/log/views/internal/util/HighlighterDropDownMenu.java
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.tptp.platform.log.views/src/org/eclipse/tptp/platform/log/views/internal/util/HighlighterDropDownMenu.java,v
>retrieving revision 1.2
>diff -u -r1.2 HighlighterDropDownMenu.java
>--- src/org/eclipse/tptp/platform/log/views/internal/util/HighlighterDropDownMenu.java	13 Apr 2007 20:20:10 -0000	1.2
>+++ src/org/eclipse/tptp/platform/log/views/internal/util/HighlighterDropDownMenu.java	8 May 2007 22:51:31 -0000
>@@ -68,11 +68,11 @@
> 					return;
> 				
> 				// get here, if different highlighters are selected or a highligher is changed to use a different color
>-				if (event.getProperty().equals("filters.highlightings.ok")){
>+				if (event.getProperty().equals("filters.highlightings.ok.press")){
> 					_highlighters.clear();
> 					updateHighlighters(_highlighters);
> 					if (_showHighlightedEventsOnly)
>-						_logViewer.updateHighlighters(_highlighters);
>+						_logViewer.updateHighlighters(_highlighters,true);
> 						CommonUIPlugin.getDefault().getPreferenceStore().firePropertyChangeEvent("filters.highlightings.ok", oldvalue, null);
> 				}
> 			}
>@@ -105,9 +105,9 @@
> 		Action showHighlightedOnly = new Action(){
> 			public void run(){
> 				_showHighlightedEventsOnly = isChecked();
>-				_logViewer.updateHighlighters(new ArrayList());
>+				_logViewer.updateHighlighters(new ArrayList(),!_showHighlightedEventsOnly);
> 				if (_showHighlightedEventsOnly){
>-					_logViewer.updateHighlighters(_highlighters);
>+					_logViewer.updateHighlighters(_highlighters,!_showHighlightedEventsOnly);
> 					CommonUIPlugin.getDefault().getPreferenceStore().firePropertyChangeEvent("filters.highlightings.ok", oldvalue, null);
> 				}
> 			}
>Index: src/org/eclipse/tptp/platform/log/views/internal/util/FiltersEditColorDialog.java
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.tptp.platform.log.views/src/org/eclipse/tptp/platform/log/views/internal/util/FiltersEditColorDialog.java,v
>retrieving revision 1.15
>diff -u -r1.15 FiltersEditColorDialog.java
>--- src/org/eclipse/tptp/platform/log/views/internal/util/FiltersEditColorDialog.java	3 May 2007 19:14:06 -0000	1.15
>+++ src/org/eclipse/tptp/platform/log/views/internal/util/FiltersEditColorDialog.java	8 May 2007 22:51:31 -0000
>@@ -528,7 +528,7 @@
> 		
> 		super.okPressed();
> 
>-		CommonUIPlugin.getDefault().getPreferenceStore().firePropertyChangeEvent("filters.highlightings.ok", null, null);
>+		CommonUIPlugin.getDefault().getPreferenceStore().firePropertyChangeEvent("filters.highlightings.ok.press", null, null);
> 	
> 		//dispose colors
> 		Iterator i = _colorsMap.keySet().iterator();
>Index: src/org/eclipse/tptp/platform/log/views/internal/views/LogContentProvider.java
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.tptp.platform.log.views/src/org/eclipse/tptp/platform/log/views/internal/views/LogContentProvider.java,v
>retrieving revision 1.34
>diff -u -r1.34 LogContentProvider.java
>--- src/org/eclipse/tptp/platform/log/views/internal/views/LogContentProvider.java	19 Mar 2007 20:03:32 -0000	1.34
>+++ src/org/eclipse/tptp/platform/log/views/internal/views/LogContentProvider.java	8 May 2007 22:51:31 -0000
>@@ -329,7 +329,7 @@
> //			}
> //		}
> 
>-		if (isModelChanged() || prepareFiltersAndSortAttributes()) {
>+		if (isModelChanged()) {// || prepareFiltersAndSortAttributes()) {
> //			rebuildAllElements(inputElement);
> 			rebuildAllElements(inputElement);
> 			_visible_roots = _visible;
>Index: src/org/eclipse/tptp/platform/log/views/internal/views/LogViewer.java
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.tptp.platform.log.views/src/org/eclipse/tptp/platform/log/views/internal/views/LogViewer.java,v
>retrieving revision 1.58
>diff -u -r1.58 LogViewer.java
>--- src/org/eclipse/tptp/platform/log/views/internal/views/LogViewer.java	13 Apr 2007 20:20:10 -0000	1.58
>+++ src/org/eclipse/tptp/platform/log/views/internal/views/LogViewer.java	8 May 2007 22:51:31 -0000
>@@ -121,10 +121,10 @@
> 	private boolean filterRefreshEvent =false;		
> 	private List highlighters = new ArrayList();
> 	
>-	public void updateHighlighters(List highlighterList){
>+	public void updateHighlighters(List highlighterList, boolean refresh){
> 		highlighters.clear();
> 		highlighters.addAll(highlighterList);
>-		this.refresh();
>+		if (refresh) this.refresh();
> 	}
> 	
> 	public SimpleSearchQuery getCurrentFilter()

Actions: View | Diff

Attachments on bug 170326: 66380