Attachment 65934 Details for Bug 141540 – Enable the JVMTI Probe Insertion in new driver

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Enable the JVMTI Probe Insertion in new driver

enable_141540.txt (text/plain), 3.47 KB, created by Liz Dancy

on 2007-05-04 11:36:08 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Dancy

Created: 2007-05-04 11:36:08 EDT

Size: 3.47 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.tptp.platform.jvmti.client
>Index: src/org/eclipse/tptp/platform/jvmti/client/internal/analysistypes/TIProbekitLaunchValidator.java
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.tptp.platform.jvmti.client/src/org/eclipse/tptp/platform/jvmti/client/internal/analysistypes/TIProbekitLaunchValidator.java,v
>retrieving revision 1.1
>diff -u -r1.1 TIProbekitLaunchValidator.java
>--- src/org/eclipse/tptp/platform/jvmti/client/internal/analysistypes/TIProbekitLaunchValidator.java	20 Apr 2007 22:53:11 -0000	1.1
>+++ src/org/eclipse/tptp/platform/jvmti/client/internal/analysistypes/TIProbekitLaunchValidator.java	4 May 2007 15:34:51 -0000
>@@ -11,10 +11,32 @@
>  **********************************************************************/
> package org.eclipse.tptp.platform.jvmti.client.internal.analysistypes;
> 
>+import java.awt.List;
>+import java.util.ArrayList;
>+import java.util.HashMap;
>+import java.util.Iterator;
>+import java.util.Map;
>+import java.util.Vector;
>+
>+import org.eclipse.core.runtime.CoreException;
> import org.eclipse.core.runtime.IStatus;
> import org.eclipse.core.runtime.Status;
> import org.eclipse.debug.core.ILaunchConfiguration;
>+import org.eclipse.hyades.internal.execution.local.control.AgentConfigurationEntry;
> import org.eclipse.hyades.trace.ui.UIPlugin;
>+import org.eclipse.hyades.trace.ui.internal.launcher.IProfileLaunchConfigurationConstants;
>+import org.eclipse.hyades.trace.ui.internal.launcher.ProfilingSetsManager;
>+import org.eclipse.hyades.trace.ui.launcher.IProfilingSet;
>+import org.eclipse.hyades.trace.ui.launcher.ProfilingAttribute;
>+import org.eclipse.jface.dialogs.MessageDialog;
>+import org.eclipse.osgi.util.NLS;
>+import org.eclipse.swt.widgets.Display;
>+import org.eclipse.tptp.platform.probekit.launch.internal.ProbekitLaunchPlugin;
>+import org.eclipse.tptp.platform.probekit.launch.internal.config.ProbekitLaunchMessages;
>+import org.eclipse.tptp.platform.probekit.registry.ProbeRegistry;
>+import org.eclipse.tptp.platform.probekit.registry.ProbeRegistryEntry;
>+import org.eclipse.tptp.platform.probekit.util.InvalidProbeBundleException;
>+import org.eclipse.tptp.platform.probekit.util.ProbeLaunchConfigString;
> import org.eclipse.tptp.trace.ui.internal.launcher.core.LauncherMessages;
> import org.eclipse.tptp.trace.ui.provisional.launcher.ILaunchValidator;
> /**
>@@ -26,7 +48,12 @@
>  */
> public class TIProbekitLaunchValidator implements ILaunchValidator 
> {
>-
>+		/**
>+		 * Called before we launch the process for this launch configuration
>+		 * so this is the final check of whether or not we ahve any probes selected.
>+		 * Must return an error message if there are no probes selected.
>+		 * @param configuration The LaunchConfiguration
>+		 */
> 		public IStatus validateConfiguration(ILaunchConfiguration configuration)
> 		{
> 			Status noProbesSelected = null;
>@@ -42,12 +69,8 @@
> 			catch(Exception e){
> 				
> 			}
>-			// Until the backend agent extension (141540) is implemented we need to
>-			// disable the UI from allowing a Profile. 
>-			// Thus, we always return this error message. The String will be removed and does
>-			// not need to be externalized
>-			return new Status(Status.ERROR, UIPlugin.getPluginId(),"Probe Insertion with JVMTI (Java 5.0) is temporarily disabled. ");
>-			//return noProbesSelected;
>+			
>+			return noProbesSelected;
> 		}
> 		
> 		public IStatus launchNotification(ILaunchConfiguration config)

Actions: View | Diff

Attachments on bug 141540: 64054 | 64200 | 64202 | 64210 | 64938 | 65067 | 65068 | 65838 | 65909 | 65934