Attachment 63902 Details for Bug 182454 – Updated patch more clearly showing the critical point

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Updated patch more clearly showing the critical point

bug182454_patch2.txt (text/plain), 1.63 KB, created by Martin Oberhuber

on 2007-04-16 09:54:01 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Oberhuber

Created: 2007-04-16 09:54:01 EDT

Size: 1.63 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.ui
>Index: UI/org/eclipse/rse/internal/ui/view/SystemView.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemView.java,v
>retrieving revision 1.90
>diff -u -r1.90 SystemView.java
>--- UI/org/eclipse/rse/internal/ui/view/SystemView.java	4 Apr 2007 13:45:20 -0000	1.90
>+++ UI/org/eclipse/rse/internal/ui/view/SystemView.java	16 Apr 2007 13:54:06 -0000
>@@ -405,6 +405,8 @@
> 		                     ((IAdaptable)b).getAdapter(ISystemViewElementAdapter.class);
> 		              }
> 		              if (identb != null){
>+		            	  //FIXME NullPointerException is possible here
>+		            	  //Unless getAbsoluteName() API is documented to never allow null return
> 		            	  if(identa.getAbsoluteName(a).equals(identb.getAbsoluteName(b))) return true;
> 		              }
> 		          }
>@@ -421,7 +423,10 @@
> 		              if(ident!=null) {
> 		                  String absName = ident.getAbsoluteName(element);
> 		                  if(absName!=null) return absName.hashCode();
>-		                  return ident.hashCode();
>+		                  //Since one adapter is typically used for many elements in RSE, performance
>+		                  //is better if the original Element's hashCode is used rather than the 
>+		                  //adapter's hashCode.
>+		                  //return ident.hashCode();
> 		              }
> 		          }		          
> 		          if (element != null) // adding check because I hit a null exception here once at startup

Actions: View | Diff

Attachments on bug 182454: 63833 | 63902