Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
View | Details | Raw Unified | Return to bug 182454 | Differences between
and this patch

Collapse All | Expand All

(-)UI/org/eclipse/rse/internal/ui/view/SystemView.java (-1 / +6 lines)
Lines 405-410 Link Here
405 
		                     ((IAdaptable)b).getAdapter(ISystemViewElementAdapter.class);
 405 
		                     ((IAdaptable)b).getAdapter(ISystemViewElementAdapter.class);
406 
		              }
 406 
		              }
407 
		              if (identb != null){
 407 
		              if (identb != null){
408 
		            	  //FIXME NullPointerException is possible here
409 
		            	  //Unless getAbsoluteName() API is documented to never allow null return
408 
		            	  if(identa.getAbsoluteName(a).equals(identb.getAbsoluteName(b))) return true;
 410 
		            	  if(identa.getAbsoluteName(a).equals(identb.getAbsoluteName(b))) return true;
409 
		              }
 411 
		              }
410 
		          }
 412 
		          }
Lines 421-427 Link Here
421 
		              if(ident!=null) {
 423 
		              if(ident!=null) {
422 
		                  String absName = ident.getAbsoluteName(element);
 424 
		                  String absName = ident.getAbsoluteName(element);
423 
		                  if(absName!=null) return absName.hashCode();
 425 
		                  if(absName!=null) return absName.hashCode();
424 
		                  return ident.hashCode();
 426 
		                  //Since one adapter is typically used for many elements in RSE, performance
427 
		                  //is better if the original Element's hashCode is used rather than the
428 
		                  //adapter's hashCode.
429 
		                  //return ident.hashCode();
425 
		              }
 430 
		              }
426 
		          }
431 
		          }
427 
		          if (element != null) // adding check because I hit a null exception here once at startup
 432 
		          if (element != null) // adding check because I hit a null exception here once at startup

Return to bug 182454