Attachment 63110 Details for Bug 175507 – Patch from K.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch from K.

patch_175507_20070405.txt (text/plain), 2.60 KB, created by Tod Creasey

on 2007-04-05 16:30:33 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tod Creasey

Created: 2007-04-05 16:30:33 EDT

Size: 2.60 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java,v
>retrieving revision 1.38
>diff -u -r1.38 FilteredItemsSelectionDialog.java
>--- Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java	29 Mar 2007 18:45:45 -0000	1.38
>+++ Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java	5 Apr 2007 17:46:54 -0000
>@@ -87,6 +87,8 @@
> import org.eclipse.swt.widgets.Label;
> import org.eclipse.swt.widgets.Menu;
> import org.eclipse.swt.widgets.Shell;
>+import org.eclipse.swt.widgets.Table;
>+import org.eclipse.swt.widgets.TableItem;
> import org.eclipse.swt.widgets.Text;
> import org.eclipse.swt.widgets.ToolBar;
> import org.eclipse.swt.widgets.ToolItem;
>@@ -527,7 +529,7 @@
> 
> 				if (selectedElements.size() > 0) {
> 					removeHistoryItemAction
>-								.setText(WorkbenchMessages.FilteredItemsSelectionDialog_removeItemsFromHistoryAction);
>+							.setText(WorkbenchMessages.FilteredItemsSelectionDialog_removeItemsFromHistoryAction);
> 
> 					manager.add(removeHistoryActionContributionItem);
> 
>@@ -809,7 +811,7 @@
> 		if (list != null && !list.getTable().isDisposed()) {
> 
> 			list.setItemCount(contentProvider.getElements(null).length);
>-			list.refresh();
>+			contentProvider.internalRefresh();
> 
> 			if (list.getTable().getItemCount() > 0) {
> 				list.getTable().setSelection(0);
>@@ -2489,6 +2491,40 @@
> 			scheduleRefresh();
> 		}
> 
>+		private void internalRefresh() {
>+
>+			int lastFilteredItemsSize = lastFilteredItems.size();
>+
>+			if (lastFilteredItems.size() != items.size())
>+				reloadCache(false, null);
>+
>+			Table table = list.getTable();
>+
>+			if (table.getItemCount() == 0 || lastFilteredItemsSize == 0
>+					|| lastCompletedFilter == null) {
>+				list.refresh(true);
>+			} else {
>+				for (int index = 0; index < lastFilteredItems.size(); index++) {
>+					Object element = lastFilteredItems.get(index);
>+					if (element != null) {
>+						TableItem tableItem = (TableItem) list
>+								.testFindItem(element);
>+						if (tableItem == null)
>+							if (index >= table.getItemCount()) {
>+								list.add(element);
>+							} else {
>+								list.replace(element, index);
>+							}
>+						else {
>+							for (int i = table.indexOf(tableItem) - 1; i > index; i--)
>+								list.remove(list.getElementAt(i));
>+						}
>+					}
>+				}
>+
>+			}
>+		}
>+
> 		/**
> 		 * Sets progress message.
> 		 *

Actions: View | Diff

Attachments on bug 175507: 59877 | 62480 | 63110 | 64188