Attachment 63038 Details for Bug 152739 – patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch

bug152739.txt (text/plain), 4.13 KB, created by Paul Klicnik

on 2007-04-05 10:36:16 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Klicnik

Created: 2007-04-05 10:36:16 EDT

Size: 4.13 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.hyades.trace.views
>Index: src/org/eclipse/hyades/trace/views/actions/internal/OpenSourceAction.java
>===================================================================
>RCS file: /cvsroot/tptp/trace/org.eclipse.hyades.trace.views/src/org/eclipse/hyades/trace/views/actions/internal/OpenSourceAction.java,v
>retrieving revision 1.1
>diff -u -r1.1 OpenSourceAction.java
>--- src/org/eclipse/hyades/trace/views/actions/internal/OpenSourceAction.java	22 Jul 2005 14:49:37 -0000	1.1
>+++ src/org/eclipse/hyades/trace/views/actions/internal/OpenSourceAction.java	5 Apr 2007 14:35:37 -0000
>@@ -11,7 +11,13 @@
>  **********************************************************************/
> package org.eclipse.hyades.trace.views.actions.internal;
> 
>+import org.eclipse.emf.ecore.EObject;
>+import org.eclipse.hyades.models.trace.TRCClass;
>+import org.eclipse.hyades.models.trace.TRCMethod;
>+import org.eclipse.hyades.models.trace.TRCMethodInvocation;
>+import org.eclipse.hyades.models.trace.TRCObject;
> import org.eclipse.hyades.trace.views.util.internal.OpenSource;
>+import org.eclipse.hyades.uml2sd.trace.selection.IEObjectSelection;
> import org.eclipse.jface.action.Action;
> import org.eclipse.jface.action.IAction;
> import org.eclipse.jface.resource.ImageDescriptor;
>@@ -31,7 +37,7 @@
> 					implements IWorkbenchWindowActionDelegate, IViewActionDelegate 
> 					//extends OpenTraceViewAction
> {
>-	protected ISelection selection;
>+	protected ISelection _selection;
> 	
> /**
>  * OpenReferencePatternView constructor comment.
>@@ -62,21 +68,30 @@
> public void run()
> {
> 	Object sel = null;
>-	
>-	if(selection != null && !selection.isEmpty())
>-	{
>-		sel = ((IStructuredSelection)selection).getFirstElement();
>+		
>+	if ( _selection != null && !_selection.isEmpty() ) {
>+		sel = ((IStructuredSelection)_selection).getFirstElement();
>+		
>+		if ( sel instanceof IEObjectSelection ) {
>+			EObject eObject = ((IEObjectSelection) sel).getEObject();
>+			
>+			if (eObject instanceof TRCMethodInvocation || 
>+					eObject instanceof TRCMethod ||
>+					eObject instanceof TRCClass ||
>+					eObject instanceof TRCObject) {
>+				sel = eObject;
>+			}			
>+		}	
> 	}
> 	
> 	OpenSource.openSource(sel);
> 	
>-	sel = null;
>-	  
>+	sel = null;	  
> }
> 
> public void selectionChanged(IAction action, ISelection selection) {
> 	
>-	this.selection = selection;
>+	this._selection = selection;
> }
> 
> /*
>@@ -91,7 +106,7 @@
> {
> 	//super.dispose();
> 	
>-	selection = null;
>+	_selection = null;
> 	
> }
> 
>Index: plugin.xml
>===================================================================
>RCS file: /cvsroot/tptp/trace/org.eclipse.hyades.trace.views/plugin.xml,v
>retrieving revision 1.22
>diff -u -r1.22 plugin.xml
>--- plugin.xml	26 Oct 2006 19:28:27 -0000	1.22
>+++ plugin.xml	5 Apr 2007 14:35:37 -0000
>@@ -480,6 +480,27 @@
>                id="org.eclipse.hyades.trace.views.actions.internal.OpenReferencePatternViewAction">
>          </action>
>       </objectContribution>
>+      
>+            <objectContribution
>+            objectClass="org.eclipse.hyades.uml2sd.trace.loaders.internal.TraceSyncMessage"
>+            id="org.eclipse.hyades.trace.views.actions.internal.LinkToSource">
>+         <action
>+               label="%27"
>+               icon="icons/full/etool16/opensource_co.gif"
>+               class="org.eclipse.hyades.trace.views.actions.internal.OpenSourceAction"
>+               id="org.eclipse.hyades.trace.views.actions.internal.OpenSourceAction">
>+         </action>
>+      </objectContribution>
>+      <objectContribution
>+            objectClass="org.eclipse.hyades.uml2sd.trace.loaders.internal.TraceSyncMessageReturn"
>+            id="org.eclipse.hyades.trace.views.actions.internal.LinkToSource">
>+         <action
>+               label="%27"
>+               icon="icons/full/etool16/opensource_co.gif"
>+               class="org.eclipse.hyades.trace.views.actions.internal.OpenSourceAction"
>+               id="org.eclipse.hyades.trace.views.actions.internal.OpenSourceAction">
>+         </action>
>+      </objectContribution>
>    </extension>
>    <extension
>          point="org.eclipse.help.contexts">

Actions: View | Diff

Attachments on bug 152739: 47324 | 63038