Attachment 61973 Details for Bug 171812 – Patch file for defect 171812.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch file for defect 171812.

RecorderPatch0312.txt (text/plain), 4.28 KB, created by Mark D Dunn

on 2007-03-26 09:37:33 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mark D Dunn

Created: 2007-03-26 09:37:33 EDT

Size: 4.28 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.hyades.test.tools.ui
>Index: src/org/eclipse/hyades/test/tools/ui/HTTPRecorderPreferences.java
>===================================================================
>RCS file: /cvsroot/tptp/test/org.eclipse.hyades.test.tools.ui/src/org/eclipse/hyades/test/tools/ui/HTTPRecorderPreferences.java,v
>retrieving revision 1.3
>diff -u -r1.3 HTTPRecorderPreferences.java
>--- src/org/eclipse/hyades/test/tools/ui/HTTPRecorderPreferences.java	29 Sep 2006 14:55:35 -0000	1.3
>+++ src/org/eclipse/hyades/test/tools/ui/HTTPRecorderPreferences.java	12 Mar 2007 14:55:13 -0000
>@@ -37,7 +37,7 @@
> 		if (Platform.getOS().equals("win32"))
> 			prefs.setDefault(ToolsUiPlugin.RECORDER_APP_ADAPTER,"org.eclipse.hyades.test.core.RecorderApplication.InternetExplorer");//$NON-NLS-1$
> 		else
>-			prefs.setDefault(ToolsUiPlugin.RECORDER_APP_ADAPTER,"-1");		  //$NON-NLS-1$
>+			prefs.setDefault(ToolsUiPlugin.RECORDER_APP_ADAPTER,"org.eclipse.hyades.test.core.RecorderApplication.Firefox");		  //$NON-NLS-1$
> 		
> 		ToolsUiPlugin.getDefault().getPreferenceStore().setDefault(UiPlugin.TEST_GENERATOR,UiPlugin.getDefault().getDefaultGeneratorID());		
> 		prefs.setDefault(ToolsUiPlugin.PROXY_PORT,DEFAULT_PORT);		 //$NON-NLS-1$
>Index: src/org/eclipse/hyades/test/tools/ui/ToolsUiPlugin.java
>===================================================================
>RCS file: /cvsroot/tptp/test/org.eclipse.hyades.test.tools.ui/src/org/eclipse/hyades/test/tools/ui/ToolsUiPlugin.java,v
>retrieving revision 1.17
>diff -u -r1.17 ToolsUiPlugin.java
>--- src/org/eclipse/hyades/test/tools/ui/ToolsUiPlugin.java	29 Sep 2006 14:55:34 -0000	1.17
>+++ src/org/eclipse/hyades/test/tools/ui/ToolsUiPlugin.java	12 Mar 2007 14:55:13 -0000
>@@ -277,7 +277,7 @@
> 		if (Platform.getOS().equals("win32"))
> 			store.setDefault(ToolsUiPlugin.RECORDER_APP_ADAPTER,"org.eclipse.hyades.test.core.RecorderApplication.InternetExplorer");//$NON-NLS-1$
> 		else
>-			store.setDefault(ToolsUiPlugin.RECORDER_APP_ADAPTER,"-1");		  //$NON-NLS-1$
>+			store.setDefault(ToolsUiPlugin.RECORDER_APP_ADAPTER,"org.eclipse.hyades.test.core.RecorderApplication.Firefox");		  //$NON-NLS-1$
> 		
> 		ToolsUiPlugin.getDefault().getPreferenceStore().setDefault(UiPlugin.TEST_GENERATOR,UiPlugin.getDefault().getDefaultGeneratorID());		
> 		store.setDefault(ToolsUiPlugin.PROXY_PORT,DEFAULT_PORT);		 //$NON-NLS-1$
>#P org.eclipse.hyades.test.core
>Index: src/org/eclipse/hyades/execution/recorder/local/appadapters/FirefoxPrefs.java
>===================================================================
>RCS file: /cvsroot/tptp/test/org.eclipse.hyades.test.core/src/org/eclipse/hyades/execution/recorder/local/appadapters/FirefoxPrefs.java,v
>retrieving revision 1.14
>diff -u -r1.14 FirefoxPrefs.java
>--- src/org/eclipse/hyades/execution/recorder/local/appadapters/FirefoxPrefs.java	18 Jan 2007 13:44:55 -0000	1.14
>+++ src/org/eclipse/hyades/execution/recorder/local/appadapters/FirefoxPrefs.java	12 Mar 2007 14:55:14 -0000
>@@ -1340,7 +1340,7 @@
> 				return "";
> 		} else if (currentOS.equals("linux")) {
> 			// bugzilla 133959 mdd make sure default it valid
>-			File browserApp = new File(WindowsLaunchPath);
>+			File browserApp = new File(LinuxLaunchPath);
> 			if (browserApp.exists())
> 				return LinuxLaunchPath;
> 			else
>Index: src/org/eclipse/hyades/execution/recorder/local/appadapters/FirefoxAdapter.java
>===================================================================
>RCS file: /cvsroot/tptp/test/org.eclipse.hyades.test.core/src/org/eclipse/hyades/execution/recorder/local/appadapters/FirefoxAdapter.java,v
>retrieving revision 1.12
>diff -u -r1.12 FirefoxAdapter.java
>--- src/org/eclipse/hyades/execution/recorder/local/appadapters/FirefoxAdapter.java	20 Jul 2006 18:27:06 -0000	1.12
>+++ src/org/eclipse/hyades/execution/recorder/local/appadapters/FirefoxAdapter.java	12 Mar 2007 14:55:14 -0000
>@@ -315,6 +315,12 @@
> 	}
> 	
> 	public void setApplicationPath(String str) {
>-		TestCorePlugin.getDefault().getPluginPreferences().setValue(PREFERENCE_PATH, str);
>+		if ( (str != null) && str.length() > 0) {
>+			TestCorePlugin.getDefault().getPluginPreferences().setValue(PREFERENCE_PATH, str);
>+		}
>+		else {
>+			String newPath = getDefaultApplicationPath();
>+			TestCorePlugin.getDefault().getPluginPreferences().setValue(PREFERENCE_PATH, str);
>+		}
> 	}
> }

Actions: View | Diff

Attachments on bug 171812: 61973