Attachment 61478 Details for Bug 178439 – patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch

WritableList.patch (text/plain), 3.74 KB, created by Brad Reynolds

on 2007-03-20 17:54:20 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brad Reynolds

Created: 2007-03-20 17:54:20 EDT

Size: 3.74 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.core.databinding
>Index: src/org/eclipse/core/databinding/observable/list/WritableList.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/WritableList.java,v
>retrieving revision 1.9
>diff -u -r1.9 WritableList.java
>--- src/org/eclipse/core/databinding/observable/list/WritableList.java	16 Mar 2007 18:00:56 -0000	1.9
>+++ src/org/eclipse/core/databinding/observable/list/WritableList.java	20 Mar 2007 21:48:51 -0000
>@@ -155,7 +155,7 @@
> 			int removeIndex = wrappedList.indexOf(element);
> 			if (removeIndex != -1) {
> 				wrappedList.remove(removeIndex);
>-				entries.add(Diffs.createListDiffEntry(removeIndex, true,
>+				entries.add(Diffs.createListDiffEntry(removeIndex, false,
> 						element));
> 			}
> 		}
>#P org.eclipse.jface.tests.databinding
>Index: src/org/eclipse/jface/tests/databinding/observable/list/WritableListTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.tests.databinding/src/org/eclipse/jface/tests/databinding/observable/list/WritableListTest.java,v
>retrieving revision 1.5
>diff -u -r1.5 WritableListTest.java
>--- src/org/eclipse/jface/tests/databinding/observable/list/WritableListTest.java	16 Mar 2007 17:59:53 -0000	1.5
>+++ src/org/eclipse/jface/tests/databinding/observable/list/WritableListTest.java	20 Mar 2007 21:48:53 -0000
>@@ -12,11 +12,15 @@
> 
> package org.eclipse.jface.tests.databinding.observable.list;
> 
>+import java.util.Arrays;
> import java.util.Collections;
> 
> import junit.framework.TestCase;
> 
> import org.eclipse.core.databinding.observable.Realm;
>+import org.eclipse.core.databinding.observable.list.IListChangeListener;
>+import org.eclipse.core.databinding.observable.list.ListChangeEvent;
>+import org.eclipse.core.databinding.observable.list.ListDiffEntry;
> import org.eclipse.core.databinding.observable.list.WritableList;
> import org.eclipse.jface.databinding.swt.SWTObservables;
> import org.eclipse.jface.tests.databinding.observable.ThreadRealm;
>@@ -43,6 +47,41 @@
> 		writableList.clear();
> 		assertEquals(0, writableList.size());
> 	}
>+    
>+    public void testRemoveAllChangeEvent() throws Exception {
>+        CurrentRealm realm = new CurrentRealm(true);
>+        
>+        WritableList list = new WritableList(realm);
>+        String element = "element";
>+        
>+        list.add(element);
>+        
>+        class ListChangeListener implements IListChangeListener {
>+            int count;
>+            ListChangeEvent event;
>+            
>+            /* (non-Javadoc)
>+             * @see org.eclipse.core.databinding.observable.list.IListChangeListener#handleListChange(org.eclipse.core.databinding.observable.list.ListChangeEvent)
>+             */
>+            public void handleListChange(ListChangeEvent event) {
>+                count++;
>+                this.event = event;
>+            }
>+        }
>+        
>+        ListChangeListener listener = new ListChangeListener();
>+        list.addListChangeListener(listener);
>+        assertEquals(0, listener.count);
>+        
>+        list.removeAll(Arrays.asList(new String[] {element}));
>+        assertEquals(1, listener.count);
>+        
>+        assertEquals(1, listener.event.diff.getDifferences().length);
>+        ListDiffEntry diffEntry = listener.event.diff.getDifferences()[0];
>+        assertFalse("addition", diffEntry.isAddition());
>+        assertEquals("element", element, diffEntry.getElement());
>+        assertEquals("position", 0, diffEntry.getPosition());
>+    }
> 
> 	public void testSetRealmChecks() throws Exception {
> 		RealmTester.exerciseCurrent(new Runnable() {

Actions: View | Diff

Attachments on bug 178439: 61478