Attachment 6089 Details for Bug 42225 – Patch to KeySupport

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to KeySupport

KeySupport-Bug42225_v2.patch (text/plain), 1.79 KB, created by Douglas Pollock

on 2003-09-12 11:05:01 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Douglas Pollock

Created: 2003-09-12 11:05:01 EDT

Size: 1.79 KB

patch

obsolete

>Index: KeySupport.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/KeySupport.java,v
>retrieving revision 1.8
>diff -u -r1.8 KeySupport.java
>--- KeySupport.java	25 Aug 2003 22:49:27 -0000	1.8
>+++ KeySupport.java	12 Sep 2003 14:58:12 -0000
>@@ -34,12 +34,34 @@
> 		if (key == 0)
> 			key = event.keyCode;
> 		else {
>-			if (0 <= key && key <= 0x1F) {
>-				if ((event.stateMask & SWT.CTRL) != 0 && event.keyCode != event.character)
>-					key += 0x40;
>-			} else {
>-				if ('a' <= key && key <= 'z')
>-					key -= 'a' - 'A';
>+			// Lower range characters might mean that the character is an escape
>+			if (0 <= key && key <= 0x1F) { 
>+				if ((event.stateMask & SWT.CTRL) != 0 && event.keyCode != event.character) {
>+					/* On Windows XP, "Ctrl+Return" is represented as character
>+					 * 0x0A and key code 0x0D.  On Linux-GTK, "Ctrl+Return" is
>+					 * represented as character 0x0D and key code 0x0D.
>+					 */
>+					if ((key == 0x0A) && (event.keyCode != 0x00)) {
>+						key = event.keyCode;
>+					} else if (event.type != SWT.Traverse) {
>+						/* Shift the Ctrl-escaped character from the lower range
>+						 * into the character range.  Note that traversal events are strange.
>+						 */
>+						key += 0x40;
>+					}
>+				}
>+				
>+			} else if ('a' <= key && key <= 'z') {
>+				// Shift lowercase letters to uppercase letters.
>+				key -= 'a' - 'A';
>+				
>+			} else if (((event.stateMask & SWT.CTRL) != 0) && (key == 0x7F)) {
>+				/* On Windows XP, "Ctrl+Backspace" is represented as character
>+				 * 0x7F and key code 0x08.  On Linux-GTK, "Ctrl+Backspace" is
>+				 * is represented as character 0x08 and key code 0x08.
>+				 */
>+				key = event.keyCode;
>+				
> 			}
> 		}
>

Actions: View | Diff

Attachments on bug 42225: 5996 | 5999 | 6089