Attachment 60853 Details for Bug 173451 – Proposed Patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed Patch

173451_patch.txt (text/plain), 3.86 KB, created by Liz Dancy

on 2007-03-14 15:54:05 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Dancy

Created: 2007-03-14 15:54:05 EDT

Size: 3.86 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.tptp.test.auto.gui
>Index: src/org/eclipse/tptp/test/auto/gui/internal/dialogs/AutoGUITestControllerDialog.java
>===================================================================
>RCS file: /cvsroot/tptp/test/org.eclipse.tptp.test.auto.gui/src/org/eclipse/tptp/test/auto/gui/internal/dialogs/AutoGUITestControllerDialog.java,v
>retrieving revision 1.3
>diff -u -r1.3 AutoGUITestControllerDialog.java
>--- src/org/eclipse/tptp/test/auto/gui/internal/dialogs/AutoGUITestControllerDialog.java	23 Aug 2006 20:40:30 -0000	1.3
>+++ src/org/eclipse/tptp/test/auto/gui/internal/dialogs/AutoGUITestControllerDialog.java	14 Mar 2007 19:31:07 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2005, 2006 IBM Corporation and others.
>+ * Copyright (c) 2005, 2007 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials 
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -573,14 +573,22 @@
> 	 * @param status The status to be printed
> 	 */
> 	public void setStatus (String status)
>-	{		
>+	{	
>+		
> 		/* The delegator has to handle this (if one exists) */
>-		if (isRoot && delegator != null)
>+		if (isRoot && delegator != null && !delegator.isShellDisposed)
> 		{
> 			delegator.setStatus(status);
> 			return;
> 		}
>-			
>+		//added for defect 173451 to ensure that in case where the widget is disposed
>+		// we switch to the correct reference (for Linux platform)
>+		// Liz Dancy
>+		else if (statuslbl.isDisposed() && delegator.isShellDisposed){
>+			
>+			this.updateDelegator(this.realParent, this.realParent);
>+			statuslbl = this.delegator.statuslbl;
>+		}	
> 		if (status == null)
> 			return;
> 		
>@@ -590,11 +598,10 @@
> 		if (finalStatus.length() > 30)
> 			toolong = true;
> 		
>-		
>+	
> 		statuslbl.setToolTipText(finalStatus);
> 		if (toolong)
> 			finalStatus = finalStatus.substring (0, 30) + "...";
>-		
> 			
> 		statuslbl.setText (finalStatus);
> 	}
>@@ -697,8 +704,9 @@
> 		
> 		AutoGUITestControllerDialog delegator = rootControl.getDelegator();
> 		/* Get rid of the last delegator */					
>-		if (activeControlDialog != null)
>+		if (activeControlDialog != null ){
> 			activeControlDialog.dispose();
>+		}
> 		
> 		delegator = new AutoGUITestControllerDialog(guardian, AutoGUITestControllerDialog.this);																
> 		delegator.setLocation(location);
>@@ -708,7 +716,7 @@
> 		delegator.setStatus(lastStatus);	
> 		delegator.actualParent = guardian;
> 		delegator.realParent = realParent;
>-				
>+		
> 		rootControl.setDelegator(delegator);
> 	}
> 	
>Index: src/org/eclipse/tptp/test/auto/gui/internal/editor/AutoGUITestCasesForm.java
>===================================================================
>RCS file: /cvsroot/tptp/test/org.eclipse.tptp.test.auto.gui/src/org/eclipse/tptp/test/auto/gui/internal/editor/AutoGUITestCasesForm.java,v
>retrieving revision 1.18
>diff -u -r1.18 AutoGUITestCasesForm.java
>--- src/org/eclipse/tptp/test/auto/gui/internal/editor/AutoGUITestCasesForm.java	2 Mar 2007 04:33:15 -0000	1.18
>+++ src/org/eclipse/tptp/test/auto/gui/internal/editor/AutoGUITestCasesForm.java	14 Mar 2007 19:31:07 -0000
>@@ -1691,6 +1691,7 @@
> 				IActionBars actionBar = AutoGUITestCasesForm.this.getEditorSite().getActionBars();
> 				if (actionBar != null)
> 				{
>+					System.out.println(undoAction);
> 					undoAction.setEnabled(undoAction.isEnabled());
> 					redoAction.setEnabled(redoAction.isEnabled());
> 					actionBar.updateActionBars();
>@@ -1704,7 +1705,14 @@
> 			
> 		public boolean isEnabled()
> 		{
>-			return undo ? linearOperationHistory.canUndo(getUndoContext()) : linearOperationHistory.canRedo(getUndoContext());
>+			try
>+			{
>+				return undo ? linearOperationHistory.canUndo(getUndoContext()) : linearOperationHistory.canRedo(getUndoContext());
>+			}
>+			catch(Exception e)
>+			{
>+				return false;
>+			}
> 		}
> 	}
>

Actions: View | Diff

Attachments on bug 173451: 60853 | 60937