Attachment 60248 Details for Bug 147435 – Patch for the problems described in this defect is attached

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch for the problems described in this defect is attached

defect_147435_patch.txt (text/plain), 1.99 KB, created by vrushali satpute

on 2007-03-05 03:06:37 EST

(hide)

Description:

Filename:

MIME Type:

Creator: vrushali satpute

Created: 2007-03-05 03:06:37 EST

Size: 1.99 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.tptp.platform.common.ui.trace
>Index: src/org/eclipse/hyades/trace/ui/internal/core/TraceHostUI.java
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.tptp.platform.common.ui.trace/src/org/eclipse/hyades/trace/ui/internal/core/TraceHostUI.java,v
>retrieving revision 1.4
>diff -u -r1.4 TraceHostUI.java
>--- src/org/eclipse/hyades/trace/ui/internal/core/TraceHostUI.java	10 Oct 2006 14:46:36 -0000	1.4
>+++ src/org/eclipse/hyades/trace/ui/internal/core/TraceHostUI.java	5 Mar 2007 07:53:43 -0000
>@@ -246,8 +246,8 @@
> 			}
> 			if (exist>0)
> 			{
>-
>-				_list.select(exist>=_list.getItemCount()?exist-1:exist);
>+				int index = _list.getSelectionIndex();
>+				_list.select(exist>=index?index:exist);
> 			}
> 			else
> 			{
>@@ -278,6 +278,7 @@
> 			if (text.equals(_list.getItem(idx).getText()))
> 			{	
> 				_list.select(idx);
>+				setHostText();
> 				return;
> 			}
> 		}
>@@ -287,6 +288,7 @@
> 		item.setImage(CommonUITraceImages.INSTANCE.getImage(CommonUITraceImages.IMG_UI_NODE));
> 
> 		_list.setSelection(new TableItem[] { item });
>+		setHostText();
> 	}
> 
> 	public void editHost(String text) {
>@@ -488,14 +490,7 @@
> 		
> 		_host.setText("");
> 		_port.setText("");
>-		
>-		if(_list.getItemCount() > 0)
>-		{
>-			if(i-1 > 0 && i-1<_list.getSelectionCount())
>-				_list.select(i-1);
>-			else
>-				_list.select(0);			
>-		}
>+		setDefaultHost();
> 	}
> 
> 	private void testConnection() {
>@@ -647,6 +642,7 @@
> 
> 		String hosts = store.getString(CommonUIConstants.HOST_KEY);
> 		addHosts(hosts);
>+		setDefaultHost();
> 		setHostText();
> 		
> 		enableButtons();
>@@ -659,7 +655,13 @@
> 	public void reset() {
> 		_list.removeAll();
> 	}
>-
>+	/**
>+	 * Set the Default Selected host in Hosts List as Localhost:port (i.e. index 1 ) 
>+	 */
>+	public void setDefaultHost(){
>+		_list.select(1);
>+		setHostText();
>+	}
> 	/**
> 	 * Sent when default selection occurs in the control.
> 	 * <p>

Actions: View | Diff

Attachments on bug 147435: 60248