Attachment 59877 Details for Bug 175507 – Proposition of changes inside patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposition of changes inside patch

patch_175507_20070227.txt (text/plain), 2.34 KB, created by Krzysztof Michalski

on 2007-02-27 10:08:17 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Krzysztof Michalski

Created: 2007-02-27 10:08:17 EST

Size: 2.34 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java,v
>retrieving revision 1.20
>diff -u -r1.20 FilteredItemsSelectionDialog.java
>--- Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java	22 Feb 2007 17:57:43 -0000	1.20
>+++ Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java	27 Feb 2007 15:03:43 -0000
>@@ -83,6 +83,7 @@
> import org.eclipse.swt.widgets.Label;
> import org.eclipse.swt.widgets.Menu;
> import org.eclipse.swt.widgets.Shell;
>+import org.eclipse.swt.widgets.Table;
> import org.eclipse.swt.widgets.Text;
> import org.eclipse.swt.widgets.ToolBar;
> import org.eclipse.swt.widgets.ToolItem;
>@@ -785,7 +786,7 @@
> 		if (list != null && !list.getTable().isDisposed()) {
> 
> 			list.setItemCount(contentProvider.getElements(null).length);
>-			list.refresh();
>+			contentProvider.internalRefresh();
> 
> 			if (list.getTable().getItemCount() > 0) {
> 				list.getTable().deselectAll();
>@@ -2433,6 +2434,43 @@
> 			scheduleRefresh();
> 		}
> 
>+		private void internalRefresh() {
>+
>+			int lastFilteredItemsSize = lastFilteredItems.size();
>+
>+			if (lastFilteredItems.size() != items.size())
>+				reloadCache(false, null);
>+
>+			Table table = list.getTable();
>+			if (table.getItemCount() == 0 || lastFilteredItemsSize == 0 || lastCompletedFilter == null) {
>+				list.refresh(true);
>+			} else {
>+				int topVisible = table.getTopIndex();
>+				int numberOfVisible = table.getClientArea().height
>+						/ table.getItems()[0].getBounds().height + 1;
>+				for (int i = 0; i < numberOfVisible; i++) {
>+
>+					int index = topVisible + i;
>+					Object newElement = null;
>+					Object oldElement = list.getElementAt(index);
>+
>+					if (index < lastFilteredItems.size()) {
>+						newElement = lastFilteredItems.get(index);
>+					}
>+
>+					if (newElement != null && oldElement != null
>+							&& !newElement.equals(oldElement)) {
>+						if (index >= table.getItemCount()) {
>+							list.add(newElement);
>+						} else {
>+							list.replace(newElement, index);
>+						}
>+					}
>+
>+				}
>+			}
>+		}
>+
> 		/**
> 		 * Sets progress message.
> 		 *

Actions: View | Diff

Attachments on bug 175507: 59877 | 62480 | 63110 | 64188