Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
View | Details | Raw Unified | Return to bug 37280 | Differences between
and this patch

Collapse All | Expand All

(-)Eclipse UI/org/eclipse/ui/internal/CyclePartAction.java (-1 / +4 lines)
Lines 14-19 Link Here
14
import java.util.Iterator;
14
import java.util.Iterator;
15
import java.util.SortedSet;
15
import java.util.SortedSet;
16
16
17
import org.eclipse.jface.preference.IPreferenceStore;
17
import org.eclipse.swt.SWT;
18
import org.eclipse.swt.SWT;
18
import org.eclipse.swt.events.FocusEvent;
19
import org.eclipse.swt.events.FocusEvent;
19
import org.eclipse.swt.events.FocusListener;
20
import org.eclipse.swt.events.FocusListener;
Lines 379-385 Link Here
379
				//printKeyEvent(e);
380
				//printKeyEvent(e);
380
				//System.out.println("accelerat:\t" + accelerator + "\t (" + KeySupport.formatStroke(Stroke.create(accelerator), true) + ")");
381
				//System.out.println("accelerat:\t" + accelerator + "\t (" + KeySupport.formatStroke(Stroke.create(accelerator), true) + ")");
381
				
382
				
382
				if ((firstKey || quickReleaseMode) && keyCode == stateMask)
383
				final IPreferenceStore store = WorkbenchPlugin.getDefault().getPreferenceStore();
384
				final boolean stickyCycle = store.getBoolean(IPreferenceConstants.STICKY_CYCLE);
385
				if ((!stickyCycle && (firstKey || quickReleaseMode)) && keyCode == stateMask)
383
					ok(dialog, table);
386
					ok(dialog, table);
384
			}
387
			}
385
		});
388
		});
(-)Eclipse UI/org/eclipse/ui/internal/IPreferenceConstants.java (+3 lines)
Lines 88-93 Link Here
88
	//Eclipse.  Will improve startup time for editors that have a long open time.
88
	//Eclipse.  Will improve startup time for editors that have a long open time.
89
	public static final String CLOSE_EDITORS_ON_EXIT = "CLOSE_EDITORS_ON_EXIT"; //$NON-NLS-1$
89
	public static final String CLOSE_EDITORS_ON_EXIT = "CLOSE_EDITORS_ON_EXIT"; //$NON-NLS-1$
90
	
90
	
91
	//Boolean: true = keep cycle part dialog open when keys released
92
	public static final String STICKY_CYCLE = "STICKY_CYCLE"; //$NON-NLS-1$
93
	
91
	//List of plugins but that extends "startup" extension point but are overriden by the user.
94
	//List of plugins but that extends "startup" extension point but are overriden by the user.
92
	//String of plugin unique ids separated by ";"
95
	//String of plugin unique ids separated by ";"
93
	public static final String PLUGINS_NOT_ACTIVATED_ON_STARTUP = "PLUGINS_NOT_ACTIVATED_ON_STARTUP"; //$NON-NLS-1$
96
	public static final String PLUGINS_NOT_ACTIVATED_ON_STARTUP = "PLUGINS_NOT_ACTIVATED_ON_STARTUP"; //$NON-NLS-1$
(-)Eclipse UI/org/eclipse/ui/internal/messages.properties (+1 lines)
Lines 740-745 Link Here
740
WorkbenchPreference.exitPromptButton = &Confirm exit when closing last window
740
WorkbenchPreference.exitPromptButton = &Confirm exit when closing last window
741
WorkbenchPreference.editorsListButton = &Show Editors drop-down
741
WorkbenchPreference.editorsListButton = &Show Editors drop-down
742
WorkbenchPreference.closeEditorsButton = Close all editors on &exit
742
WorkbenchPreference.closeEditorsButton = Close all editors on &exit
743
WorkbenchPreference.stickyCycleButton = Keep next/previous part dialog open
743
WorkbenchPreference.showTasks = Show &Problems view when build has errors or warnings
744
WorkbenchPreference.showTasks = Show &Problems view when build has errors or warnings
744
WorkbenchPreference.replaceCurrent = &Replace current
745
WorkbenchPreference.replaceCurrent = &Replace current
745
WorkbenchPreference.control = Ctrl
746
WorkbenchPreference.control = Ctrl
(-)Eclipse UI/org/eclipse/ui/internal/dialogs/WorkbenchPreferencePage.java (+10 lines)
Lines 31-36 Link Here
31
	private Button autoSaveAllButton;
31
	private Button autoSaveAllButton;
32
	private Button refreshButton;
32
	private Button refreshButton;
33
	private Button showTasks;
33
	private Button showTasks;
34
	private Button stickyCycleButton;
34
	private Button exitPromptButton;
35
	private Button exitPromptButton;
35
	private IntegerFieldEditor saveInterval;
36
	private IntegerFieldEditor saveInterval;
36
37
Lines 82-87 Link Here
82
		showTasks.setText(WorkbenchMessages.getString("WorkbenchPreference.showTasks")); //$NON-NLS-1$
83
		showTasks.setText(WorkbenchMessages.getString("WorkbenchPreference.showTasks")); //$NON-NLS-1$
83
		showTasks.setFont(font);
84
		showTasks.setFont(font);
84
85
86
		stickyCycleButton = new Button(composite, SWT.CHECK);
87
		stickyCycleButton.setText(WorkbenchMessages.getString("WorkbenchPreference.stickyCycleButton")); //$NON-NLS-1$
88
		stickyCycleButton.setFont(composite.getFont());
89
85
		createSpace(composite);
90
		createSpace(composite);
86
		createSaveIntervalGroup(composite);
91
		createSaveIntervalGroup(composite);
87
		
92
		
Lines 95-100 Link Here
95
		refreshButton.setSelection(store.getBoolean(IPreferenceConstants.REFRESH_WORKSPACE_ON_STARTUP));
100
		refreshButton.setSelection(store.getBoolean(IPreferenceConstants.REFRESH_WORKSPACE_ON_STARTUP));
96
		exitPromptButton.setSelection(store.getBoolean(IPreferenceConstants.EXIT_PROMPT_ON_CLOSE_LAST_WINDOW));
101
		exitPromptButton.setSelection(store.getBoolean(IPreferenceConstants.EXIT_PROMPT_ON_CLOSE_LAST_WINDOW));
97
		showTasks.setSelection(store.getBoolean(IPreferenceConstants.SHOW_TASKS_ON_BUILD));
102
		showTasks.setSelection(store.getBoolean(IPreferenceConstants.SHOW_TASKS_ON_BUILD));
103
		stickyCycleButton.setSelection(store.getBoolean(IPreferenceConstants.STICKY_CYCLE));
98
		
104
		
99
		return composite;
105
		return composite;
100
	}
106
	}
Lines 296-301 Link Here
296
		refreshButton.setSelection(store.getDefaultBoolean(IPreferenceConstants.REFRESH_WORKSPACE_ON_STARTUP));
302
		refreshButton.setSelection(store.getDefaultBoolean(IPreferenceConstants.REFRESH_WORKSPACE_ON_STARTUP));
297
		exitPromptButton.setSelection(store.getDefaultBoolean(IPreferenceConstants.EXIT_PROMPT_ON_CLOSE_LAST_WINDOW));
303
		exitPromptButton.setSelection(store.getDefaultBoolean(IPreferenceConstants.EXIT_PROMPT_ON_CLOSE_LAST_WINDOW));
298
		showTasks.setSelection(store.getBoolean(IPreferenceConstants.SHOW_TASKS_ON_BUILD));
304
		showTasks.setSelection(store.getBoolean(IPreferenceConstants.SHOW_TASKS_ON_BUILD));
305
		stickyCycleButton.setSelection(store.getBoolean(IPreferenceConstants.STICKY_CYCLE));
299
		saveInterval.loadDefault();
306
		saveInterval.loadDefault();
300
		
307
		
301
		openOnSingleClick = store.getDefaultBoolean(IPreferenceConstants.OPEN_ON_SINGLE_CLICK); //$NON-NLS-1$
308
		openOnSingleClick = store.getDefaultBoolean(IPreferenceConstants.OPEN_ON_SINGLE_CLICK); //$NON-NLS-1$
Lines 343-348 Link Here
343
350
344
		//store the preference for bringing task view to front on build
351
		//store the preference for bringing task view to front on build
345
		store.setValue(IPreferenceConstants.SHOW_TASKS_ON_BUILD, showTasks.getSelection());
352
		store.setValue(IPreferenceConstants.SHOW_TASKS_ON_BUILD, showTasks.getSelection());
353
354
		// store the keep cycle part dialogs sticky preference
355
		store.setValue(IPreferenceConstants.STICKY_CYCLE, stickyCycleButton.getSelection());
346
356
347
		long oldSaveInterval = description.getSnapshotInterval() / 60000;
357
		long oldSaveInterval = description.getSnapshotInterval() / 60000;
348
		long newSaveInterval = new Long(saveInterval.getStringValue()).longValue();
358
		long newSaveInterval = new Long(saveInterval.getStringValue()).longValue();

Return to bug 37280