Attachment 59013 Details for Bug 174233 – proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] proposed patch

anchor.patch (text/plain), 2.37 KB, created by Darin Wright

on 2007-02-14 16:44:02 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Darin Wright

Created: 2007-02-14 16:44:02 EST

Size: 2.37 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.debug.ui
>Index: ui/org/eclipse/debug/ui/InspectPopupDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/InspectPopupDialog.java,v
>retrieving revision 1.22
>diff -u -r1.22 InspectPopupDialog.java
>--- ui/org/eclipse/debug/ui/InspectPopupDialog.java	4 Jan 2007 17:38:52 -0000	1.22
>+++ ui/org/eclipse/debug/ui/InspectPopupDialog.java	14 Feb 2007 21:33:00 -0000
>@@ -86,7 +86,8 @@
>      * Creates a new inspect popup.
>      * 
>      * @param shell The parent shell
>-     * @param anchor point at which to anchor the popup in Display coordinates
>+     * @param anchor point at which to anchor the popup in Display coordinates. Since
>+     *  3.3 <code>null</code> indicates a default location should be used.
>      * @param commandId The command id to be used for persistence of 
>      * the dialog (possibly <code>null</code>)
>      * @param expression The expression being inspected
>Index: ui/org/eclipse/debug/ui/DebugPopup.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/DebugPopup.java,v
>retrieving revision 1.14
>diff -u -r1.14 DebugPopup.java
>--- ui/org/eclipse/debug/ui/DebugPopup.java	25 Sep 2006 14:08:19 -0000	1.14
>+++ ui/org/eclipse/debug/ui/DebugPopup.java	14 Feb 2007 21:33:00 -0000
>@@ -63,7 +63,8 @@
>     /**
>      * Constructs a new popup dialog of type <code>PopupDialog.INFOPOPUPRESIZE_SHELLSTYLE</code>
>      * @param parent The parent shell
>-     * @param anchor point at which to anchor the popup dialog in Display coordinate space
>+     * @param anchor point at which to anchor the popup dialog in Display coordinate space.
>+     * 	Since 3.3, <code>null</code> can be specified to use a default anchor point
>      * @param commandId The command id to be used for persistence of 
>      *  the dialog, or <code>null</code>
>      */
>@@ -159,6 +160,9 @@
>      * @return the initial location of the shell
>      */
>     protected Point getInitialLocation(Point initialSize) {
>+    	if (fAnchor == null) {
>+    		return super.getInitialLocation(initialSize);
>+    	}
>         Point point = fAnchor;
>         Rectangle monitor = getShell().getMonitor().getClientArea();
>         if (monitor.width < point.x + initialSize.x) {

Actions: View | Diff

Attachments on bug 174233: 59013