Attachment 58641 Details for Bug 160970 – Fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix

patch160970.txt (text/plain), 2.63 KB, created by Nédélec Patrick

on 2007-02-09 05:01:27 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Nédélec Patrick

Created: 2007-02-09 05:01:27 EST

Size: 2.63 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.hyades.test.tools.core
>Index: src/org/eclipse/hyades/test/tools/core/internal/common/codegen/JavaGenerator.java
>===================================================================
>RCS file: /cvsroot/tptp/test/org.eclipse.hyades.test.tools.core/src/org/eclipse/hyades/test/tools/core/internal/common/codegen/JavaGenerator.java,v
>retrieving revision 1.15
>diff -u -r1.15 JavaGenerator.java
>--- src/org/eclipse/hyades/test/tools/core/internal/common/codegen/JavaGenerator.java	9 Feb 2007 09:57:30 -0000	1.15
>+++ src/org/eclipse/hyades/test/tools/core/internal/common/codegen/JavaGenerator.java	9 Feb 2007 09:59:18 -0000
>@@ -1,10 +1,10 @@
> /**********************************************************************
>- * Copyright (c) 2005, 2006 IBM Corporation and others.
>+ * Copyright (c) 2005, 2007 IBM Corporation and others.
>  * All rights reserved.   This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>  * http://www.eclipse.org/legal/epl-v10.html
>- * $Id: JavaGenerator.java,v 1.15 2007/02/09 09:57:30 pnedelec Exp $
>+ * $Id: JavaGenerator.java,v 1.14 2007/02/08 17:32:31 pnedelec Exp $
>  * 
>  * Contributors: 
>  * IBM - Initial API and implementation
>@@ -287,17 +287,19 @@
> 			
> 			// Package name
> 			String packageName = getPackageName(getTestSuite());
>-			if (packageName == null) {
>-				status.addFatalError("No package specified by the test suite");
>-			} else {
>-				IStatus st = JavaConventions.validatePackageName(packageName);
>-				if (st.getSeverity() != IStatus.OK) {
>-					if (st.getSeverity() == IStatus.ERROR) {
>-						// Replace the diagnosis of JDT with something more explicit
>-						status.addFatalError(NLS.bind(CommonPluginMessages.E_CODEGEN_PACK_DIAG, st.getMessage()));
>-					}
>-				}
>-			}
>+            if (packageName == null) {
>+                status.addFatalError("No package specified by the test suite");
>+            } else if (packageName.length() == 0) {
>+                //- Default package used: nothing to do
>+            }else {
>+                IStatus st = JavaConventions.validatePackageName(packageName);
>+                if (st.getSeverity() != IStatus.OK) {
>+                    if (st.getSeverity() == IStatus.ERROR) {
>+                        // Replace the diagnosis of JDT with something more explicit
>+                        status.addFatalError(NLS.bind(CommonPluginMessages.E_CODEGEN_PACK_DIAG, st.getMessage()));
>+                    }
>+                }
>+            }
> 			monitor.worked(1);
> 			
> 			// Class name

Actions: View | Diff

Attachments on bug 160970: 58641