Attachment 57945 Details for Bug 136399 – Proposed short term fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed short term fix

136399patch.txt (text/plain), 4.44 KB, created by Valentin Baciu

on 2007-01-31 16:34:43 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Valentin Baciu

Created: 2007-01-31 16:34:43 EST

Size: 4.44 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.wst.xml.core
>Index: src-contentmodel/org/eclipse/wst/xml/core/internal/contentmodel/modelqueryimpl/CMDocumentManagerImpl.java
>===================================================================
>RCS file: /cvsroot/webtools/wst/components/xml/plugins/org.eclipse.wst.xml.core/src-contentmodel/org/eclipse/wst/xml/core/internal/contentmodel/modelqueryimpl/CMDocumentManagerImpl.java,v
>retrieving revision 1.5
>diff -u -r1.5 CMDocumentManagerImpl.java
>--- src-contentmodel/org/eclipse/wst/xml/core/internal/contentmodel/modelqueryimpl/CMDocumentManagerImpl.java	24 May 2006 14:14:36 -0000	1.5
>+++ src-contentmodel/org/eclipse/wst/xml/core/internal/contentmodel/modelqueryimpl/CMDocumentManagerImpl.java	31 Jan 2007 21:31:09 -0000
>@@ -50,6 +50,7 @@
>     this.cmDocumentReferenceProvider = cmDocumentReferenceProvider;
>     setPropertyEnabled(PROPERTY_AUTO_LOAD, true);
>     setPropertyEnabled(PROPERTY_USE_CACHED_RESOLVED_URI, false);
>+    setPropertyEnabled(PROPERTY_PERFORM_URI_RESOLUTION, true);
>   }         
> 
>        
>@@ -157,7 +158,16 @@
> 
>     if (getPropertyEnabled(PROPERTY_AUTO_LOAD))
>     {
>-      resolvedURI = lookupOrCreateResolvedURI(publicId, systemId);
>+      // See https://bugs.eclipse.org/bugs/show_bug.cgi?id=136399
>+    	
>+      if (getPropertyEnabled(PROPERTY_PERFORM_URI_RESOLUTION))
>+      {
>+	    resolvedURI = lookupOrCreateResolvedURI(publicId, systemId);
>+      }
>+      else
>+      {
>+        resolvedURI = systemId;
>+      }
>     }    
>     else
>     {
>Index: src-contentmodel/org/eclipse/wst/xml/core/internal/contentmodel/modelquery/CMDocumentManager.java
>===================================================================
>RCS file: /cvsroot/webtools/wst/components/xml/plugins/org.eclipse.wst.xml.core/src-contentmodel/org/eclipse/wst/xml/core/internal/contentmodel/modelquery/CMDocumentManager.java,v
>retrieving revision 1.4
>diff -u -r1.4 CMDocumentManager.java
>--- src-contentmodel/org/eclipse/wst/xml/core/internal/contentmodel/modelquery/CMDocumentManager.java	24 May 2006 14:14:33 -0000	1.4
>+++ src-contentmodel/org/eclipse/wst/xml/core/internal/contentmodel/modelquery/CMDocumentManager.java	31 Jan 2007 21:31:09 -0000
>@@ -59,6 +59,14 @@
> 	public static final String PROPERTY_USE_CACHED_RESOLVED_URI = "useCachedResovledURI"; //$NON-NLS-1$
> 
> 	/**
>+	 * See https://bugs.eclipse.org/bugs/show_bug.cgi?id=136399
>+	 * Allows a client to control whether the document manager attempts to resolve a
>+	 * CM document's URI. When set to false, the CM systemID will be assumed to point
>+	 * to an already resolved URI. By default this property is set to true.
>+	 */
>+	public static final String PROPERTY_PERFORM_URI_RESOLUTION = "performURIResolution"; //$NON-NLS-1$
>+
>+	/**
> 	 * Set the enabled state of a property.
> 	 */
> 	public void setPropertyEnabled(String propertyName, boolean enabled);
>#P org.eclipse.wst.html.core
>Index: src/org/eclipse/wst/html/core/internal/modelquery/XHTMLAssociationProvider.java
>===================================================================
>RCS file: /cvsroot/webtools/wst/components/html/plugins/org.eclipse.wst.html.core/src/org/eclipse/wst/html/core/internal/modelquery/XHTMLAssociationProvider.java,v
>retrieving revision 1.7
>diff -u -r1.7 XHTMLAssociationProvider.java
>--- src/org/eclipse/wst/html/core/internal/modelquery/XHTMLAssociationProvider.java	12 Jun 2006 21:29:59 -0000	1.7
>+++ src/org/eclipse/wst/html/core/internal/modelquery/XHTMLAssociationProvider.java	31 Jan 2007 21:31:10 -0000
>@@ -13,6 +13,7 @@
> 
> import org.eclipse.wst.common.uriresolver.internal.provisional.URIResolver;
> import org.eclipse.wst.xml.core.internal.contentmodel.CMDocument;
>+import org.eclipse.wst.xml.core.internal.contentmodel.modelquery.CMDocumentManager;
> import org.eclipse.wst.xml.core.internal.contentmodel.modelqueryimpl.XMLAssociationProvider;
> import org.eclipse.wst.xml.core.internal.contentmodel.util.CMDocumentCache;
> import org.w3c.dom.Document;
>@@ -39,6 +40,14 @@
> 	public XHTMLAssociationProvider(CMDocumentCache cache, URIResolver idResolver) {
> 		super(cache);
> 		this.idResolver = idResolver;
>+		
>+		// See https://bugs.eclipse.org/bugs/show_bug.cgi?id=136399. If the CM document URI
>+		// is resolved and cached at this level instruct the CM model manager to avoid 
>+		// re-resolving the URI.
>+		
>+		if (USE_QUICK_CACHE) {
>+			documentManager.setPropertyEnabled(CMDocumentManager.PROPERTY_PERFORM_URI_RESOLUTION, false);
>+		}
> 	}
> 
> 	/**

Actions: View | Diff

Attachments on bug 136399: 57945 | 64195