Attachment 56624 Details for Bug 134730 – handlind inv.images

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] handlind inv.images

patch.txt (text/plain), 2.87 KB, created by bugzzy

on 2007-01-09 07:51:53 EST

(hide)

Description:

Filename:

MIME Type:

Creator: bugzzy

Created: 2007-01-09 07:51:53 EST

Size: 2.87 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/dialogs/AboutDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/AboutDialog.java,v
>retrieving revision 1.25
>diff -u -r1.25 AboutDialog.java
>--- Eclipse UI/org/eclipse/ui/internal/dialogs/AboutDialog.java	8 May 2006 20:55:46 -0000	1.25
>+++ Eclipse UI/org/eclipse/ui/internal/dialogs/AboutDialog.java	9 Jan 2007 12:22:16 -0000
>@@ -16,6 +16,7 @@
> import org.eclipse.core.runtime.IBundleGroup;
> import org.eclipse.core.runtime.IBundleGroupProvider;
> import org.eclipse.core.runtime.IProduct;
>+import org.eclipse.core.runtime.IStatus;
> import org.eclipse.core.runtime.Platform;
> import org.eclipse.jface.dialogs.IDialogConstants;
> import org.eclipse.jface.resource.ImageDescriptor;
>@@ -45,8 +46,11 @@
> import org.eclipse.ui.internal.IWorkbenchHelpContextIds;
> import org.eclipse.ui.internal.ProductProperties;
> import org.eclipse.ui.internal.WorkbenchMessages;
>+import org.eclipse.ui.internal.WorkbenchPlugin;
> import org.eclipse.ui.internal.about.AboutBundleGroupData;
> import org.eclipse.ui.internal.about.AboutFeaturesButtonManager;
>+import org.eclipse.ui.internal.misc.StatusUtil;
>+import org.eclipse.ui.statushandling.StatusManager;
> 
> /**
>  * Displays information about the product.
>@@ -209,7 +213,13 @@
>             ImageDescriptor imageDescriptor = ProductProperties
>                     .getAboutImage(product);
>             if (imageDescriptor != null) {
>-				aboutImage = imageDescriptor.createImage();
>+            	try {
>+            		aboutImage = imageDescriptor.createImage();
>+            	} catch(RuntimeException e) {
>+            		String message = "Invalid about image for product " + product.getId(); //$NON-NLS-1$
>+	                IStatus status = StatusUtil.newStatus(WorkbenchPlugin.PI_WORKBENCH, message, e); 
>+	            	StatusManager.getManager().handle(status);
>+            	}
> 			}
> 
>             // if the about image is small enough, then show the text
>@@ -369,8 +379,19 @@
> 
>         Button button = new Button(parent, SWT.FLAT | SWT.PUSH);
>         button.setData(info);
>-        featureImage = desc.createImage();
>-        images.add(featureImage);
>+        
>+        try {
>+        	featureImage = desc.createImage();
>+    	} catch(RuntimeException e) {
>+    		String message = "Invalid feature image for feature " + info.getId(); //$NON-NLS-1$
>+            IStatus status = StatusUtil.newStatus(WorkbenchPlugin.PI_WORKBENCH, message, e); 
>+        	StatusManager.getManager().handle(status);
>+    	}
>+        
>+        if (featureImage != null) {
>+        	images.add(featureImage);
>+        }
>+        
>         button.setImage(featureImage);
>         button.setToolTipText(info.getProviderName());
>

Actions: View | Diff

Attachments on bug 134730: 56624