Attachment 55934 Details for Bug 168356 – Patch that disposes controls

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Patch that disposes controls

hide-jira-controls.patch (text/plain), 2.35 KB, created by Steffen Pingel

on 2006-12-19 22:09:44 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Steffen Pingel

Created: 2006-12-19 22:09:44 EST

Size: 2.35 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylar.jira.ui
>Index: src/org/eclipse/mylar/internal/jira/core/ui/wizards/JiraQueryPage.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.mylar/org.eclipse.mylar.jira.ui/src/org/eclipse/mylar/internal/jira/core/ui/wizards/JiraQueryPage.java,v
>retrieving revision 1.3
>diff -u -r1.3 JiraQueryPage.java
>--- src/org/eclipse/mylar/internal/jira/core/ui/wizards/JiraQueryPage.java	7 Dec 2006 04:30:37 -0000	1.3
>+++ src/org/eclipse/mylar/internal/jira/core/ui/wizards/JiraQueryPage.java	20 Dec 2006 03:07:52 -0000
>@@ -208,7 +208,8 @@
> 
> 		c = new Composite(parent, SWT.NONE);
> 		c.setLayout(new GridLayout(3, false));
>-
>+		setControl(c);
>+		
> 		if (namedQuery) {
> 			Label lblName = new Label(c, SWT.NONE);
> 			final GridData gridData = new GridData();
>@@ -680,7 +681,6 @@
> 		} else {
> 			loadFromWorkingCopy();
> 		}
>-		setControl(c);
> 	}
> 
> 	private void createReportedInViewer(Composite c) {
>#P org.eclipse.mylar.tasks.ui
>Index: src/org/eclipse/mylar/internal/tasks/ui/TaskSearchPage.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.mylar/org.eclipse.mylar.tasks.ui/src/org/eclipse/mylar/internal/tasks/ui/TaskSearchPage.java,v
>retrieving revision 1.7
>diff -u -r1.7 TaskSearchPage.java
>--- src/org/eclipse/mylar/internal/tasks/ui/TaskSearchPage.java	7 Dec 2006 04:38:04 -0000	1.7
>+++ src/org/eclipse/mylar/internal/tasks/ui/TaskSearchPage.java	20 Dec 2006 03:07:54 -0000
>@@ -125,6 +125,9 @@
> 					try {
> 						searchPage.createControl(fParentComposite);
> 					} catch (Exception e) {
>+						if (searchPage.getControl() != null) {
>+							searchPage.getControl().dispose();
>+						}
> 						searchPage.dispose();
> 						searchPage = new DeadSearchPage(repository) {
> 							@Override
>@@ -152,8 +155,6 @@
> 						searchPage.createControl(fParentComposite);
> 						MylarStatusHandler.log(e, "Error occurred while constructing search page for "
> 								+ repository.getUrl() + " [" + repository.getKind() + "]");
>-						// searchPage.getControl().dispose();
>-
> 					}
> 				}
> 				return searchPage;
>@@ -309,5 +310,14 @@
> 			return taskRepository;
> 		}
> 
>+		@Override
>+		public void setVisible(boolean visible) {
>+			super.setVisible(visible);
>+			
>+			if (visible) {
>+				scontainer.setPerformActionEnabled(false);
>+			}
>+		}
>+		
> 	}
> }

Actions: View

Attachments on bug 168356: 55834 | 55934 | 55935