Attachment 54970 Details for Bug 166482 – Patch showing my intention

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch showing my intention

org.eclipse.ui.ide_patch.txt (text/plain), 3.42 KB, created by Dirk Segelhorst

on 2006-12-04 09:32:07 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Dirk Segelhorst

Created: 2006-12-04 09:32:07 EST

Size: 3.42 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.ide
>Index: src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java
>===================================================================
>RCS file: F:/cvsrepo/easee_wh/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java,v
>retrieving revision 1.1
>diff -u -r1.1 IDEInternalPreferences.java
>--- src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java	1 Dec 2006 15:50:38 -0000	1.1
>+++ src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java	4 Dec 2006 07:06:08 -0000
>@@ -78,4 +78,7 @@
>     
> //  The list of defined tasks filters
>     public static final String BOOKMARKS_FILTERS = "BOOKMARKS_FILTERS"; //$NON-NLS-1$
>+    
>+    //default "Group by"
>+    public static final String DEFAULT_GROUP_BY = "DEFAULT_GROUP_BY"; //$NON-NLS-1$
> }
>Index: src/org/eclipse/ui/internal/ide/IDEPreferenceInitializer.java
>===================================================================
>RCS file: F:/cvsrepo/easee_wh/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEPreferenceInitializer.java,v
>retrieving revision 1.1
>diff -u -r1.1 IDEPreferenceInitializer.java
>--- src/org/eclipse/ui/internal/ide/IDEPreferenceInitializer.java	1 Dec 2006 15:50:38 -0000	1.1
>+++ src/org/eclipse/ui/internal/ide/IDEPreferenceInitializer.java	4 Dec 2006 07:06:08 -0000
>@@ -70,6 +70,9 @@
> 
> 		node.putBoolean(IDEInternalPreferences.LIMIT_TASKS, true);
> 		node.putInt(IDEInternalPreferences.TASKS_LIMIT, 100);
>+        
>+        //Set up default group by
>+        node.put(IDEInternalPreferences.DEFAULT_GROUP_BY, "");
> 	}
> 
> 	private String getHelpSeparatorKey(String groupId) {
>Index: src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java
>===================================================================
>RCS file: F:/cvsrepo/easee_wh/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java,v
>retrieving revision 1.1
>diff -u -r1.1 MarkerSupportRegistry.java
>--- src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java	1 Dec 2006 15:50:35 -0000	1.1
>+++ src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java	4 Dec 2006 07:06:08 -0000
>@@ -32,6 +32,7 @@
> import org.eclipse.core.runtime.dynamichelpers.IExtensionTracker;
> import org.eclipse.osgi.util.NLS;
> import org.eclipse.ui.PlatformUI;
>+import org.eclipse.ui.internal.ide.IDEInternalPreferences;
> import org.eclipse.ui.internal.ide.IDEWorkbenchPlugin;
> 
> /**
>@@ -712,8 +713,28 @@
> 	 * @return IField
> 	 */
> 	public IField getDefaultGroup() {
>-
>-		return (IField) markerGroups.get(SEVERITY_ID);
>-	}
>-
>+	    //read preference here:
>+        final String preference = IDEWorkbenchPlugin.getDefault().getPreferenceStore().getString(getDefaultGroupByName());
>+        if(preference==null || preference.equals("")) {
>+            return (IField) markerGroups.get(SEVERITY_ID);
>+        } else {
>+            Object markerGroup = markerGroups.get(preference);
>+            if(markerGroup!=null) {
>+                return (IField) markerGroup;   
>+            }
>+        }
>+        
>+        //return the default default group in case the preference was not found:
>+        return (IField) markerGroups.get(SEVERITY_ID);
>+	}
>+
>+    /**
>+     * Method getDefaultGroupByName.
>+     *
>+     * @return The group by preference.
>+     */
>+    String getDefaultGroupByName() {
>+        return IDEInternalPreferences.DEFAULT_GROUP_BY;
>+    }
>+    
> }

Actions: View | Diff

Attachments on bug 166482: 54970