Attachment #54970 for bug #166482

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

View | Details | Raw Unified | Return to bug 166482
Collapse All | Expand All

Lines 78-81 Link Here

(-)src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java (+3 lines)
78		78
79	// The list of defined tasks filters	79	// The list of defined tasks filters
80	public static final String BOOKMARKS_FILTERS = "BOOKMARKS_FILTERS"; //$NON-NLS-1$	80	public static final String BOOKMARKS_FILTERS = "BOOKMARKS_FILTERS"; //$NON-NLS-1$
		81
		82	//default "Group by"
		83	public static final String DEFAULT_GROUP_BY = "DEFAULT_GROUP_BY"; //$NON-NLS-1$
81	}	84	}

Lines 70-75 Link Here

(-)src/org/eclipse/ui/internal/ide/IDEPreferenceInitializer.java (+3 lines)
70		70
71	node.putBoolean(IDEInternalPreferences.LIMIT_TASKS, true);	71	node.putBoolean(IDEInternalPreferences.LIMIT_TASKS, true);
72	node.putInt(IDEInternalPreferences.TASKS_LIMIT, 100);	72	node.putInt(IDEInternalPreferences.TASKS_LIMIT, 100);
		73
		74	//Set up default group by
		75	node.put(IDEInternalPreferences.DEFAULT_GROUP_BY, "");
73	}	76	}
74		77
75	private String getHelpSeparatorKey(String groupId) {	78	private String getHelpSeparatorKey(String groupId) {




import org.eclipse.core.runtime.dynamichelpers.IExtensionTracker;
import org.eclipse.osgi.util.NLS;
import org.eclipse.ui.PlatformUI;
import org.eclipse.ui.internal.ide.IDEInternalPreferences;
import org.eclipse.ui.internal.ide.IDEWorkbenchPlugin;

/**

	 * @return IField
	 */
	public IField getDefaultGroup() {
	    //read preference here:
        final String preference = IDEWorkbenchPlugin.getDefault().getPreferenceStore().getString(getDefaultGroupByName());
        if(preference==null || preference.equals("")) {
            return (IField) markerGroups.get(SEVERITY_ID);
        } else {
            Object markerGroup = markerGroups.get(preference);
            if(markerGroup!=null) {
                return (IField) markerGroup;   
            }
        }
        
        //return the default default group in case the preference was not found:
        return (IField) markerGroups.get(SEVERITY_ID);
	}

    /**
     * Method getDefaultGroupByName.
     *
     * @return The group by preference.
     */
    String getDefaultGroupByName() {
        return IDEInternalPreferences.DEFAULT_GROUP_BY;
    }
    
}

Return to bug 166482

Lines 32-37 Link Here

(-)src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java (-4 / +25 lines)
32	import org.eclipse.core.runtime.dynamichelpers.IExtensionTracker;	32	import org.eclipse.core.runtime.dynamichelpers.IExtensionTracker;
33	import org.eclipse.osgi.util.NLS;	33	import org.eclipse.osgi.util.NLS;
34	import org.eclipse.ui.PlatformUI;	34	import org.eclipse.ui.PlatformUI;
		35	import org.eclipse.ui.internal.ide.IDEInternalPreferences;
35	import org.eclipse.ui.internal.ide.IDEWorkbenchPlugin;	36	import org.eclipse.ui.internal.ide.IDEWorkbenchPlugin;
36		37
37	/**	38	/**
Lines 712-719 Link Here
712	* @return IField	713	* @return IField
713	*/	714	*/
714	public IField getDefaultGroup() {	715	public IField getDefaultGroup() {
715		716	//read preference here:
716	return (IField) markerGroups.get(SEVERITY_ID);	717	final String preference = IDEWorkbenchPlugin.getDefault().getPreferenceStore().getString(getDefaultGroupByName());
717	}	718	if(preference==null \|\| preference.equals("")) {
718		719	return (IField) markerGroups.get(SEVERITY_ID);
		720	} else {
		721	Object markerGroup = markerGroups.get(preference);
		722	if(markerGroup!=null) {
		723	return (IField) markerGroup;
		724	}
		725	}
		726
		727	//return the default default group in case the preference was not found:
		728	return (IField) markerGroups.get(SEVERITY_ID);
		729	}
		730
		731	/**
		732	* Method getDefaultGroupByName.
		733	*
		734	* @return The group by preference.
		735	*/
		736	String getDefaultGroupByName() {
		737	return IDEInternalPreferences.DEFAULT_GROUP_BY;
		738	}
		739
719	}	740	}