Attachment 53741 Details for Bug 163726 – Here's the proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Here's the proposed fix

launch-shortcut-patch-2.txt (text/plain), 2.89 KB, created by Alexander Simbirtsev

on 2006-11-13 07:59:49 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Alexander Simbirtsev

Created: 2006-11-13 07:59:49 EST

Size: 2.89 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.hyades.trace.ui
>Index: src/org/eclipse/tptp/trace/ui/internal/launcher/core/LauncherUtility.java
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.hyades.trace.ui/src/org/eclipse/tptp/trace/ui/internal/launcher/core/LauncherUtility.java,v
>retrieving revision 1.13
>diff -u -r1.13 LauncherUtility.java
>--- src/org/eclipse/tptp/trace/ui/internal/launcher/core/LauncherUtility.java	6 Nov 2006 23:32:34 -0000	1.13
>+++ src/org/eclipse/tptp/trace/ui/internal/launcher/core/LauncherUtility.java	13 Nov 2006 12:54:24 -0000
>@@ -1237,19 +1237,28 @@
> 	}
> 	
> 	public static ILaunchConfiguration addExtendedConfigurationDefaults(final ILaunchConfiguration config) {
>-		ILaunchConfigurationWorkingCopy wc;
>+		ILaunchConfiguration result = config;
> 		try {
>-			wc = config.getWorkingCopy();
>-			ProfilingSetsManager manager = ProfilingSetsManager.instance();
>-			IPreferenceStore store = UIPlugin.getDefault().getPreferenceStore();
>-			boolean autoFilteringCriteriaDefault = store.getBoolean(TraceConstants.AUTO_FILTER_CRITERIA_OPTION);
>-			wc.setAttribute(IProfileLaunchConfigurationConstants.ATTR_AUTO_FILTER_CRITERIA, autoFilteringCriteriaDefault);
>-			wc.setAttribute(IProfileLaunchConfigurationConstants.ATTR_PROFILING_SET, manager.getDefaultSet() == null ? null : manager.getDefaultSet().getId());
>-			wc.setAttribute(IProfileLaunchConfigurationConstants.ATTR_FILTER_SET, autoFilteringCriteriaDefault ? TraceConstants.AUTO_GENERATED_FILTER_SET : LauncherConstants.DEFAULT_FILTER_ID);
>-			return wc.doSave();
>+			ILaunchConfigurationWorkingCopy wc = config.getWorkingCopy();
>+			addExtendedAttributes(wc);
>+			result = wc.doSave();
> 		} catch (CoreException exception) {
> 		}
>-		return config;
>+		return result;
>+	}
>+
>+	public static ILaunchConfiguration addExtendedConfigurationDefaults(final ILaunchConfigurationWorkingCopy wc) {
>+		addExtendedAttributes(wc);
>+		return wc;
>+	}
>+
>+	private static void addExtendedAttributes(ILaunchConfigurationWorkingCopy wc) {
>+		ProfilingSetsManager manager = ProfilingSetsManager.instance();
>+		IPreferenceStore store = UIPlugin.getDefault().getPreferenceStore();
>+		boolean autoFilteringCriteriaDefault = store.getBoolean(TraceConstants.AUTO_FILTER_CRITERIA_OPTION);
>+		wc.setAttribute(IProfileLaunchConfigurationConstants.ATTR_AUTO_FILTER_CRITERIA, autoFilteringCriteriaDefault);
>+		wc.setAttribute(IProfileLaunchConfigurationConstants.ATTR_PROFILING_SET, manager.getDefaultSet() == null ? null : manager.getDefaultSet().getId());
>+		wc.setAttribute(IProfileLaunchConfigurationConstants.ATTR_FILTER_SET, autoFilteringCriteriaDefault ? TraceConstants.AUTO_GENERATED_FILTER_SET : LauncherConstants.DEFAULT_FILTER_ID);
> 	}
> 	
> 	/* ----------------------------------------------------------------------------------------------------------------------------------------- */

Actions: View | Diff

Attachments on bug 163726: 53741