Attachment 53522 Details for Bug 17102 – Fix to SaveablesList reference counting

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix to SaveablesList reference counting

saveableslist-patch.txt (text/plain), 1.35 KB, created by Jon Burton

on 2006-11-08 19:04:29 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Jon Burton

Created: 2006-11-08 19:04:29 EST

Size: 1.35 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/SaveablesList.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SaveablesList.java,v
>retrieving revision 1.8.4.2
>diff -u -r1.8.4.2 SaveablesList.java
>--- Eclipse UI/org/eclipse/ui/internal/SaveablesList.java	16 Aug 2006 03:53:07 -0000	1.8.4.2
>+++ Eclipse UI/org/eclipse/ui/internal/SaveablesList.java	8 Nov 2006 05:47:13 -0000
>@@ -98,9 +98,8 @@
> 			modelsForSource = new HashSet();
> 			modelMap.put(source, modelsForSource);
> 		}
>-		if (modelsForSource.add(model)) {
>-			result = incrementRefCount(modelRefCounts, model);
>-		}
>+		modelsForSource.add(model);
>+		result = incrementRefCount(modelRefCounts, model);
> 		return result;
> 	}
> 
>@@ -150,12 +149,15 @@
> 			modelsForSource = new HashSet();
> 			modelMap.put(source, modelsForSource);
> 		}
>-		if (modelsForSource.remove(model)) {
>-			result = decrementRefCount(modelRefCounts, model);
>-			if (modelsForSource.isEmpty()) {
>-				modelMap.remove(source);
>+		result = decrementRefCount(modelRefCounts, model);
>+		if (result) {
>+			if (modelsForSource.remove(model)) {
>+				if (modelsForSource.isEmpty()) {
>+					modelMap.remove(source);
>+				}
> 			}
> 		}
>+
> 		return result;
> 	}
>

Actions: View | Diff

Attachments on bug 17102: 53522 | 53603