Attachment #50596 for bug #158065

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

View | Details | Raw Unified | Return to bug 158065
Collapse All | Expand All

Lines 258-265 Link Here

(-)src/org/eclipse/jface/internal/databinding/provisional/DataBindingContext.java 18 Aug 2006 03:58:11 -0000 1.6 (-1 / +2 lines)
258	IObservable modelObservable, BindSpec bindSpec) {	258	IObservable modelObservable, BindSpec bindSpec) {
259	Binding result = doCreateBinding(targetObservable, modelObservable,	259	Binding result = doCreateBinding(targetObservable, modelObservable,
260	bindSpec, this);	260	bindSpec, this);
261	if (result != null)	261	if (result != null) {
262	return result;	262	return result;
		263	}
263	throw new BindingException(	264	throw new BindingException(
264	"No binding found for target: " + targetObservable.getClass().getName() + ", model: " + modelObservable.getClass().getName()); //$NON-NLS-1$ //$NON-NLS-2$	265	"No binding found for target: " + targetObservable.getClass().getName() + ", model: " + modelObservable.getClass().getName()); //$NON-NLS-1$ //$NON-NLS-2$
265	}	266	}

Lines 315-321 Link Here

(-)src/org/eclipse/jface/internal/databinding/internal/viewers/StructuredViewerObservableCollectionWithLabels.java 19 Jun 2006 13:43:33 -0000 1.6 (-1 / +6 lines)
315	}	315	}
316	Object oldObject = null;	316	Object oldObject = null;
317	oldObject = wrappedList.remove(index);	317	oldObject = wrappedList.remove(index);
318	elementsAsSet.remove(oldObject);	318	if (!elementsAsSet.remove(oldObject)) {
		319	throw new IllegalArgumentException("wrappedList.size() != elementsAsSet.size(): (Did you implement equals() and hashCode() correctly?)"); //$NON-NLS-1$
		320	}
319	removeFromViewer(oldObject);	321	removeFromViewer(oldObject);
320	fireListChange(Diffs.createListDiff(Diffs.createListDiffEntry(	322	fireListChange(Diffs.createListDiff(Diffs.createListDiffEntry(
321	index, false, oldObject)));	323	index, false, oldObject)));
Lines 333-338 Link Here
333	Collections.EMPTY_SET));	335	Collections.EMPTY_SET));
334	addToViewer(index, element);	336	addToViewer(index, element);
335	}	337	}
		338	if (wrappedList.size() != elementsAsSet.size()) {
		339	throw new IllegalArgumentException("wrappedList.size() != elementsAsSet.size(): (Did you implement equals() and hashCode() correctly?)"); //$NON-NLS-1$
		340	}
336	}	341	}
337		342
338	public boolean addAll(int index, Collection c) {	343	public boolean addAll(int index, Collection c) {

Lines 204-210 Link Here

(-)src/org/eclipse/jface/internal/databinding/internal/ValueBinding.java 8 Jun 2006 22:40:42 -0000 1.4 (-1 / +5 lines)
204	fireBindingEvent(e);	204	fireBindingEvent(e);
205	} catch (Exception ex) {	205	} catch (Exception ex) {
206	ValidationError error = ValidationError.error(BindingMessages	206	ValidationError error = ValidationError.error(BindingMessages
207	.getString("ValueBinding_ErrorWhileSettingValue")); //$NON-NLS-1$	207	.getString("ValueBinding_ErrorWhileSettingValue"), ex); //$NON-NLS-1$
208	validationErrorObservable.setValue(error);	208	validationErrorObservable.setValue(error);
209	} finally {	209	} finally {
210	updating = false;	210	updating = false;
Lines 281-286 Link Here
281	doValidate(target.getValue());	281	doValidate(target.getValue());
282	e.pipelinePosition = BindingEvent.PIPELINE_AFTER_VALIDATE;	282	e.pipelinePosition = BindingEvent.PIPELINE_AFTER_VALIDATE;
283	fireBindingEvent(e);	283	fireBindingEvent(e);
		284	} catch (Exception ex) {
		285	ValidationError error = ValidationError.error(BindingMessages
		286	.getString("ValueBinding_ErrorWhileSettingValue"), ex); //$NON-NLS-1$
		287	validationErrorObservable.setValue(error);
284	} finally {	288	} finally {
285	updating = false;	289	updating = false;
286	}	290	}




            * Holds the current error or warning message.
            */
           public final String message;
   
   /**
    * Holds the exception that was thrown, if any.
    */
   public final Throwable exception;
           
   /**
    * A convenience factory for {@link #ERROR} ValidationErrors.
    * 
    * @param message The error message
    * @return A new ValidationError representing the error
    */
   public static ValidationError error(String message) {
      return new ValidationError(ERROR, message, null);
   }
   
   /**
    * A convenience factory for {@link #ERROR} ValidationErrors.
    * 
    * @param message The error message
    * @param exception The exception that was thrown
    * @return A new ValidationError representing the error
    */
   public static ValidationError error(String message, Throwable exception) {
      return new ValidationError(ERROR, message, exception);
   }
   
           /**
            * A convenience factory for {@link #WARNING} ValidationErrors.
            * 

            * @return A new ValidationError representing the warning
            */
           public static ValidationError warning(String message) {
                      return new ValidationError(WARNING, message, null);
           }
           
           /**

            * 
            * @param status either {@link #WARNING} or {@link #ERROR}
            * @param message An error message string or warning.
          * @param exception The exception that was thrown or null.
            */
          public ValidationError(int status, String message, Throwable exception) {
                       this.status = status;
                       this.message = message;
      this.exception = exception;
           }
           
           public String toString() {




           public Object getValueType() {
                       return valueType;
           }

   /* (non-Javadoc)
    * @see org.eclipse.jface.internal.databinding.provisional.observable.AbstractObservable#addChangeListener(org.eclipse.jface.internal.databinding.provisional.observable.IChangeListener)
    */
   public void addChangeListener(IChangeListener listener) {
      super.addChangeListener(listener);
      // If somebody is listening, we need to make sure we attach our own
      // listeners
      getValue();
   }
   
   /* (non-Javadoc)
    * @see org.eclipse.jface.internal.databinding.provisional.observable.value.AbstractObservableValue#addValueChangeListener(org.eclipse.jface.internal.databinding.provisional.observable.value.IValueChangeListener)
    */
   public void addValueChangeListener(IValueChangeListener listener) {
      super.addValueChangeListener(listener);
      // If somebody is listening, we need to make sure we attach our own
      // listeners
      getValue();
   }
 }


Return to bug 158065

Lines 167-170 Link Here

(-)src/org/eclipse/jface/internal/databinding/provisional/observable/value/ComputedValue.java 13 Mar 2006 04:58:19 -0000 1.2 (+21 lines)
167	public Object getValueType() {	167	public Object getValueType() {
168	return valueType;	168	return valueType;
169	}	169	}
		170
		171	/* (non-Javadoc)
		172	* @see org.eclipse.jface.internal.databinding.provisional.observable.AbstractObservable#addChangeListener(org.eclipse.jface.internal.databinding.provisional.observable.IChangeListener)
		173	*/
		174	public void addChangeListener(IChangeListener listener) {
		175	super.addChangeListener(listener);
		176	// If somebody is listening, we need to make sure we attach our own
		177	// listeners
		178	getValue();
		179	}
		180
		181	/* (non-Javadoc)
		182	* @see org.eclipse.jface.internal.databinding.provisional.observable.value.AbstractObservableValue#addValueChangeListener(org.eclipse.jface.internal.databinding.provisional.observable.value.IValueChangeListener)
		183	*/
		184	public void addValueChangeListener(IValueChangeListener listener) {
		185	super.addValueChangeListener(listener);
		186	// If somebody is listening, we need to make sure we attach our own
		187	// listeners
		188	getValue();
		189	}
		190	}
170		191

Lines 36-52 Link Here

(-)src/org/eclipse/jface/internal/databinding/provisional/validation/ValidationError.java 19 Jun 2006 14:09:52 -0000 1.4 (-12 / +30 lines)
36	* Holds the current error or warning message.	36	* Holds the current error or warning message.
37	*/	37	*/
38	public final String message;	38	public final String message;
		39
		40	/**
		41	* Holds the exception that was thrown, if any.
		42	*/
		43	public final Throwable exception;
39		44
40	/**	45	/**
41	* A convenience factory for {@link #ERROR} ValidationErrors.	46	* A convenience factory for {@link #ERROR} ValidationErrors.
42	*	47	*
43	* @param message The error message	48	* @param message The error message
44	* @return A new ValidationError representing the error	49	* @return A new ValidationError representing the error
45	*/	50	*/
46	public static ValidationError error(String message) {	51	public static ValidationError error(String message) {
47	return new ValidationError(ERROR, message);	52	return new ValidationError(ERROR, message, null);
48	}	53	}
49		54
		55	/**
		56	* A convenience factory for {@link #ERROR} ValidationErrors.
		57	*
		58	* @param message The error message
		59	* @param exception The exception that was thrown
		60	* @return A new ValidationError representing the error
		61	*/
		62	public static ValidationError error(String message, Throwable exception) {
		63	return new ValidationError(ERROR, message, exception);
		64	}
		65
50	/**	66	/**
51	* A convenience factory for {@link #WARNING} ValidationErrors.	67	* A convenience factory for {@link #WARNING} ValidationErrors.
52	*	68	*
Lines 54-60 Link Here
54	* @return A new ValidationError representing the warning	70	* @return A new ValidationError representing the warning
55	*/	71	*/
56	public static ValidationError warning(String message) {	72	public static ValidationError warning(String message) {
57	return new ValidationError(WARNING, message);	73	return new ValidationError(WARNING, message, null);
58	}	74	}
59		75
60	/**	76	/**
Lines 62-71 Link Here
62	*	78	*
63	* @param status either {@link #WARNING} or {@link #ERROR}	79	* @param status either {@link #WARNING} or {@link #ERROR}
64	* @param message An error message string or warning.	80	* @param message An error message string or warning.
		81	* @param exception The exception that was thrown or null.
65	*/	82	*/
66	public ValidationError(int status, String message) {	83	public ValidationError(int status, String message, Throwable exception) {
67	this.status = status;	84	this.status = status;
68	this.message = message;	85	this.message = message;
		86	this.exception = exception;
69	}	87	}
70		88
71	public String toString() {	89	public String toString() {