Attachment 50239 Details for Bug 157445 – Fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix

157445_PopupDialog_patch.txt (text/plain), 1.56 KB, created by Markus Keller

on 2006-09-15 05:34:46 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Markus Keller

Created: 2006-09-15 05:34:46 EDT

Size: 1.56 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface
>Index: src/org/eclipse/jface/dialogs/PopupDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface/src/org/eclipse/jface/dialogs/PopupDialog.java,v
>retrieving revision 1.25
>diff -u -r1.25 PopupDialog.java
>--- src/org/eclipse/jface/dialogs/PopupDialog.java	8 May 2006 20:57:00 -0000	1.25
>+++ src/org/eclipse/jface/dialogs/PopupDialog.java	15 Sep 2006 09:38:15 -0000
>@@ -367,7 +367,7 @@
> 				 */
> 				if (listenToDeactivate && event.widget == getShell()
> 						&& getShell().getShells().length == 0) {
>-					close();
>+					asyncClose();
> 				} else {
> 					/* We typically ignore deactivates to work around platform-specific
> 					 * event ordering.  Now that we've ignored whatever we were supposed to,
>@@ -399,7 +399,7 @@
> 			parentDeactivateListener= new Listener() {
> 				public void handleEvent(Event event) {
> 					if (listenToParentDeactivate) {
>-						close();
>+						asyncClose();
> 					} else {
> 						// Our first deactivate, now start listening on the Mac.
> 						listenToParentDeactivate = listenToDeactivate;
>@@ -416,6 +416,15 @@
> 		});
> 	}
> 
>+	private void asyncClose() {
>+		// workaround for https://bugs.eclipse.org/bugs/show_bug.cgi?id=152010
>+		getShell().getDisplay().asyncExec(new Runnable() {
>+			public void run() {
>+				close();
>+			}
>+		});
>+	}
>+	
> 	/**
> 	 * The <code>PopupDialog</code> implementation of this <code>Window</code>
> 	 * method creates and lays out the top level composite for the dialog. It

Actions: View | Diff

Attachments on bug 157445: 50239