Attachment 48158 Details for Bug 154289 – EditorValue not saved

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] EditorValue not saved

patch.txt (text/plain), 1.86 KB, created by Thomas Schindl

on 2006-08-18 04:08:20 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Schindl

Created: 2006-08-18 04:08:20 EDT

Size: 1.86 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface
>Index: src/org/eclipse/jface/viewers/TreeEditorImpl.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeEditorImpl.java,v
>retrieving revision 1.11
>diff -u -r1.11 TreeEditorImpl.java
>--- src/org/eclipse/jface/viewers/TreeEditorImpl.java	17 Aug 2006 19:34:41 -0000	1.11
>+++ src/org/eclipse/jface/viewers/TreeEditorImpl.java	18 Aug 2006 08:09:54 -0000
>@@ -310,7 +310,7 @@
>      * by delegating to the cell modifier.
>      */
>     private void saveEditorValue(CellEditor cellEditor, Item treeItem) {
>-    	ViewerColumn part = (ViewerColumn)treeItem.getData(ViewerColumn.COLUMN_VIEWER_KEY);
>+    	ViewerColumn part = viewer.getViewerColumn(columnNumber);
>     	
>     	if( part != null && part.getEditingSupport() != null ) {
>         	part.getEditingSupport().setValue(treeItem.getData(), cellEditor.getValue());
>Index: src/org/eclipse/jface/viewers/TableEditorImpl.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/TableEditorImpl.java,v
>retrieving revision 1.11
>diff -u -r1.11 TableEditorImpl.java
>--- src/org/eclipse/jface/viewers/TableEditorImpl.java	17 Aug 2006 19:34:41 -0000	1.11
>+++ src/org/eclipse/jface/viewers/TableEditorImpl.java	18 Aug 2006 08:09:53 -0000
>@@ -305,7 +305,7 @@
>      * by delegating to the cell modifier.
>      */
>     private void saveEditorValue(CellEditor cellEditor, Item tableItem) {
>-    	ViewerColumn part = (ViewerColumn)tableItem.getData(ViewerColumn.COLUMN_VIEWER_KEY);
>+    	ViewerColumn part = viewer.getViewerColumn(columnNumber);
>     	
>         if( part != null && part.getEditingSupport() != null ) {
>         	part.getEditingSupport().setValue(tableItem.getData(), cellEditor.getValue());

Actions: View | Diff

Attachments on bug 154289: 48157 | 48158 | 48252 | 48253